Added unit tests for DateUtils class #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Test | ||
| public void testNowInput() { | ||
| TimeZone tz = TimeZone.getTimeZone(TimeZone.getAvailableIDs()[0]); | ||
| DateUtils util = new DateUtils(Locale.US, tz); |
There was a problem hiding this comment.
You can move the DateUtils setup into a @Before method since it's used in all tests.
androidlibrary_lib/src/test/java/org/opendatakit/utilities/DateUtilsTest.java
Outdated
Show resolved
Hide resolved
|
Feedback noted @Lamouresparus . I have made the updates. Please let me know what you think |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues #507 and #510 by improving the test coverage of the DateUtils class
What was done
Added tests for the
tryParseDurationmethod, testing for different valid and invalid duration inputs and making sure each input string returns the correct integer according to the respective unit.Note: As a result of the slight delay in milliseconds in returning the output, the tests make assertions omitting the milliseconds