-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Syncing or Downloading Reduced Size Images: Services #219
Open
oagashe
wants to merge
13
commits into
odk-x:development
Choose a base branch
from
oagashe:development
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? Also need an authorization to run tests. |
oagashe
changed the title
Syncing or Download Reduced Size Images
Syncing or Downloading Reduced Size Images: Services
Dec 2, 2021
wbrunette
reviewed
Dec 7, 2021
...n/java/org/opendatakit/services/sync/service/logic/ProcessManifestContentAndFileChanges.java
Outdated
Show resolved
Hide resolved
@wbrunette |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows functionality to do a full sync while downloading reduced size images, or just downloading all attachments while getting the images reduced size.
Involves:
-UI modification
-logic for determining whether an image is reduced size and we want to overwrite that with a full size image.
Depends on #219 and odk-x/androidlibrary#217 to work.
@wbrunette