onboarding server framework by snoek100 · Pull Request #1383 · odoo/tutorials

snoek100 · 2026-08-17T11:20:40Z

No description provided.

robodoo · 2026-08-17T11:20:43Z

yoba-odoo

Good work 💪
Can you just keep it one commit per chapter? That would be easier to follow

Also the commit titles has to follow the guidelines here

yoba-odoo · 2026-08-18T08:52:13Z

@@ -0,0 +1 @@
+from . import models


Keep in mind to always add a newline in the end of each file

yoba-odoo · 2026-08-18T08:54:39Z

+    'views': [
+
+    ],


We can remove this I don't think we need it since we are already defining the views in the data key

yoba-odoo · 2026-08-18T08:57:14Z

+        <field name="model">estate.property</field>
+        <field name="arch" type="xml">
+            <search string="Search">
+                <field name="name" string="Title"/>


This will work fine but to avoid setting a string for each field in each view you can add this string to the field definition in python and it will be used everywhere you call this field in XML

yoba-odoo · 2026-08-18T08:58:26Z

+from odoo import fields, models
+from dateutil.relativedelta import relativedelta
+
+class TestModel(models.Model):


I know this is a tutorial 😅 but avoid to name anything test unless it is a real test as this is the convention we use for unit test files

yoba-odoo

Nice work 👌
While applying the changes try to make the ci/* checks pass

yoba-odoo · 2026-08-20T12:31:58Z

+        string='type',
+        selection=[('north', 'North'), ('south', 'South'), ('East', 'east'), ('West', 'west')],
+    )
+    total_area = fields.Integer(string="Total Area", compute="_compute_total_surface")


Suggested change

total_area = fields.Integer(string="Total Area", compute="_compute_total_surface")

total_area = fields.Integer(string="Total Area", compute="_compute_total_area")

We normally tend to name the compute method after the exact name of field

yoba-odoo · 2026-08-20T13:39:04Z

+        return True
+
+    @api.ondelete(at_uninstall=False)
+    def ondelete(self):


It is kinda a nitpick but we usually name those method as _unlink_**** for example:

Suggested change

def ondelete(self):

def _unlink_except_new_cancelled(self):

yoba-odoo · 2026-08-20T13:42:36Z

+        for record in self:
+            if record.create_date:
+                record.date_deadline = record.create_date + relativedelta(days=record.validity)
+            else:
+                record.date_deadline = fields.Datetime.today() + relativedelta(days=record.validity)


Suggested change

for record in self:

if record.create_date:

record.date_deadline = record.create_date + relativedelta(days=record.validity)

else:

record.date_deadline = fields.Datetime.today() + relativedelta(days=record.validity)

for record in self:

check_date = record.create_date if record.create_date else fields.Datetime.today()

record.date_deadline = check_date + relativedelta(days=record.validity)

To avoid duplicating some of the code we can do this, wdyt?

yoba-odoo · 2026-08-20T13:43:17Z

+
+    # ===========button actions===========
+    def action_accept(self):
+


Nitpick 😇 not a needed line

yoba-odoo · 2026-08-20T13:50:59Z

+            property = self.env["estate.property"].browse(to_create["property_id"])
+            new_bid = to_create["price"]
+            for offer in property.offer_ids:
+                if offer.price > new_bid:


since you introduced an order for the offers here https://github.com/odoo/tutorials/pull/1383/changes#diff-8000c23a2907f34f0cc387be9dc4178411fda81b674724854bd4d048f9e11b16R9 the recordset will be ordered upon price by default so normally offer_ids[0] will have the offer that has the highest price

yoba-odoo · 2026-08-20T13:54:58Z

@@ -0,0 +1,10 @@
+from odoo import fields, models
+
+class InheritedModel(models.Model):


When inherit a model we name the class the same as the parent class

yoba-odoo · 2026-08-20T13:58:00Z

@@ -0,0 +1,62 @@
+<?xml version="1.0"?>


it is a better practice to have a XML view file for each model.
So here separate the estate_property and the estate_property_type and estate_property_tag and estate_property_offer views each in a separate file

yoba-odoo · 2026-08-20T13:58:13Z

@@ -0,0 +1,180 @@
+<?xml version="1.0"?>


same as above ☝️

prevent other people from breaking the reset of the estate's garden area and orientation when a garden is present

In order to improve readability estate views which were all in one file have been refactored such that every view has their own file named according to their id.

…n be set. Since the requirements don't allow the property type to be edited directly in the list view a field has been created in the form view to allow setting the property type.

added a component containing a button and a counter such that the button increments the counter. also added a component which creates its own children buttons such that it's possible to have a global counter of all the children buttons.

added init and manifest

e1d7982

snoek100 added 3 commits August 17, 2026 15:55

added all the functionality until the basic views of server framework

cb84f6e

end of day 1

99af35b

server framework 101 end of chapter 6

a969dc2

yoba-odoo reviewed Aug 18, 2026

View reviewed changes

snoek100 added 9 commits August 18, 2026 15:17

finished server framework 101 chapter 9

031009b

actually finished server framework 101 chapter 9

fa0cc1c

finished server framework 101 chapter 10

b4428f5

finished server framework 101 chapter 11

e63118d

finished server framework 101 chapter 12

1ac00c6

finished chapter server framework chapter 13

c3c4378

finished server framework 101 chapter 14

0d07749

fixed styling changes

721c3c7

ammended styling fix

873b465

yoba-odoo reviewed Aug 20, 2026

View reviewed changes

snoek100 added 4 commits August 21, 2026 09:10

[ADD] estate: added test cases for estate class

65c6202

prevent other people from breaking the reset of the estate's garden area and orientation when a garden is present

[REF] estate: separated estate views into seperat files

c1476ea

In order to improve readability estate views which were all in one file have been refactored such that every view has their own file named according to their id.

[FIX] estate: added a field for the property type form so its name ca…

20f44e2

…n be set. Since the requirements don't allow the property type to be edited directly in the list view a field has been created in the form view to allow setting the property type.

[ADD] added buttons and counters

d5e25b3

added a component containing a button and a counter such that the button increments the counter. also added a component which creates its own children buttons such that it's possible to have a global counter of all the children buttons.

	total_area = fields.Integer(string="Total Area", compute="_compute_total_surface")
	total_area = fields.Integer(string="Total Area", compute="_compute_total_area")


		# ===========button actions===========
		def action_accept(self):

		@@ -0,0 +1,10 @@
		from odoo import fields, models

		class InheritedModel(models.Model):

Uh oh!

Conversation

snoek100 commented Aug 17, 2026

Uh oh!

robodoo commented Aug 17, 2026

Uh oh!

yoba-odoo left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

yoba-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

yoba-odoo left a comment •

edited

Loading