Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't move count_in_cpr without moving shadow_count #720

Draft
wants to merge 1 commit into
base: devel
Choose a base branch
from

Conversation

Wetmelon
Copy link
Collaborator

No description provided.

@Wetmelon Wetmelon added the bug label Sep 26, 2022
@samuelsadok
Copy link
Member

I'm currently too detached from this part of the codebase to quickly judge if this change is good. Is it tested? Please also add a note to the changelog.

@Wetmelon
Copy link
Collaborator Author

It's not ready to merge (not tested). We originally added this when we were having some issues with absolute encoder async, but we ended up adding the latched value at the top of the function, so this should be redundant (but potentially troublesome).

I'm on the fence about changing it at all tbh.

@samuelsadok samuelsadok marked this pull request as draft September 27, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants