Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows usage of UV, CPython and pypy mirrors #147

Conversation

Coruscant11
Copy link
Contributor

@Coruscant11 Coruscant11 commented Jul 26, 2024

Fixes #146

I added also some tests ensuring the non-regression 🙂

@Coruscant11 Coruscant11 changed the title Add Python & UV repository source configuration by environment variable Allows usage of UV, CPython and pypy mirrors Jul 26, 2024
@Coruscant11 Coruscant11 force-pushed the feat/custom-source-repositories branch 6 times, most recently from 5f5a2c4 to b0802fa Compare July 26, 2024 14:00
@Coruscant11
Copy link
Contributor Author

I added our company to the Users page of the doc 😄

@Coruscant11
Copy link
Contributor Author

Coruscant11 commented Jul 28, 2024

@ofek Hi! Thanks for approving the build !
Got the notification of the build 🙂

It seems the variables are not in the good order in the validate step:

PYAPP_UV_ONLY_BOOTSTRAP               | PYAPP_UV_REPOSITORY
PYAPP_UV_REPOSITORY                   | PYAPP_UV_ONLY_BOOTSTRAP
PYAPP_UV_VERSION                      | PYAPP_UV_VERSION

Any idea how to fix it? 🤔

@ofek
Copy link
Owner

ofek commented Jul 28, 2024

Thanks for this!

@Coruscant11
Copy link
Contributor Author

Coruscant11 commented Jul 28, 2024

  • It's alphabetical.

Oh, makes sense! I will fix it, thanks. 😆

You mean, adding the same fork/mirror configuration by environment variable feature to hatch ?
If yes, then yes of course! 🙂

@Coruscant11 Coruscant11 force-pushed the feat/custom-source-repositories branch 2 times, most recently from 4d96764 to 49c0a3d Compare July 28, 2024 20:55
@ofek
Copy link
Owner

ofek commented Jul 28, 2024

No I actually mean to copy the concept over here. Someone opened up a PR implementing this same solution (it's very logical) but then I thought about how it would play out in practice so I came up with that way pypa/hatch#1455 (comment)

@Coruscant11
Copy link
Contributor Author

No I actually mean to copy the concept over here. Someone opened up a PR implementing this same solution (it's very logical) but then I thought about how it would play out in practice so I came up with that way pypa/hatch#1455 (comment)

Oh, okay I see!
Yes of course, I will use this tomorrow then 🙂

Thanks for the suggestion!

@Coruscant11 Coruscant11 force-pushed the feat/custom-source-repositories branch from 49c0a3d to 9668d79 Compare July 30, 2024 06:40
@Coruscant11
Copy link
Contributor Author

Coruscant11 commented Jul 30, 2024

Hi @ofek, I upaded the PR.

Here is how it looks now:
image

Is this what you had in mind? 🙂

I have to update the documentation

@Coruscant11 Coruscant11 force-pushed the feat/custom-source-repositories branch from 9668d79 to 2809c6f Compare July 30, 2024 07:05
@Coruscant11
Copy link
Contributor Author

Updated the variable name to PYAPP_DISTRIBUTION_SOURCE_<NAME> in order to be consistent with other options names. I updated the doc too.

Have stuff to do, I will update very soon the doc for the UV customization.

@Coruscant11 Coruscant11 force-pushed the feat/custom-source-repositories branch from 2809c6f to 8126616 Compare July 30, 2024 07:26
@ofek
Copy link
Owner

ofek commented Jul 30, 2024

At a glance this is exactly what I had in mind, thanks! I will take a look this weekend.

@Coruscant11 Coruscant11 force-pushed the feat/custom-source-repositories branch from 8126616 to 0e1c5e1 Compare July 31, 2024 14:47
@Coruscant11
Copy link
Contributor Author

Normally fixed the tests 🙂

Also the updated environment variable name update:
image

Feel free to tell me if you want to change the name of PYAPP_UV_CUSTOM_SOURCE. Maybe just PYAPP_UV_SOURCE ? As you wish!

See you this weekend 😄 Take care

@ofek
Copy link
Owner

ofek commented Aug 3, 2024

It looks like your branch doesn't allow pushes, I'm going to create a new branch with your commits #152

@ofek
Copy link
Owner

ofek commented Aug 4, 2024

Superseded by #153

@ofek ofek closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow usage of UV, CPython and pypy mirrors
2 participants