Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new theme: powerline-shell wrapper for fish #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leleliu008
Copy link

add new theme: powerline-shell wrapper for fish

@leleliu008 leleliu008 requested a review from a team as a code owner October 3, 2019 14:12
@derekstavis
Copy link
Member

Would you mind removing the -theme from the end of the filename? It's not necessary because the package type is defined by the package definition file.

@leleliu008
Copy link
Author

@derekstavis can't remove the -theme from the end of the filename for the following reasons:

  1. a package who is named powerline which type is plugin already exist. it is wrapped for powerline-status
  2. my new package's type is theme, it is wrapped for powerline-shell

@bobthecow
Copy link
Member

installing this theme sets fish keybindings to vi mode (and this persists even after removing the theme). this feels like … not the sort of thing a theme should do :)

@leleliu008
Copy link
Author

@bobthecow I have removed the key_bindings.fish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants