-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add top menu to app #585
base: main
Are you sure you want to change the base?
Add top menu to app #585
Conversation
guergana
commented
Oct 8, 2024
•
edited
Loading
edited
- fixes ODE - Top menu options #417
@roll I am thinking if it's possible to pass a parameter to the openDialog action... by the way the software is structured now it's not possible... do you have any ideas on how we could implement this? There is no way to access the 'Add external file' dialog tab without trying to pass a parameter. |
Deploying opendataeditor with Cloudflare Pages
|
@guergana
Or you can have to dialog names |
Thanks, @roll . I've found another way. It works like a charm!!!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I tested it works good aside one typo making errors/source to collide
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I testes it on Mac.
File menu: when I first select Add and then New file, it works OK. However, when I go to the file menu and then select Add + New folder or External data, it does not work (the add data dialog does not pop-up).
Something similar occurs with the View menu. If you select a file from the left menu of the ODE and then you click on View--Metadata, Errors panel or Source it does not work.
The Help menu works OK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested PR 471. It works OK.
@roll the PR is ready for review again. |