Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top menu to app #585

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

Add top menu to app #585

wants to merge 16 commits into from

Conversation

guergana
Copy link
Collaborator

@guergana guergana commented Oct 8, 2024

@guergana guergana changed the title 471/prototype menu ipc Add top menu to app Oct 8, 2024
@guergana guergana changed the title Add top menu to app [WiP] Add top menu to app Oct 8, 2024
@guergana
Copy link
Collaborator Author

guergana commented Oct 9, 2024

@roll I am thinking if it's possible to pass a parameter to the openDialog action... by the way the software is structured now it's not possible... do you have any ideas on how we could implement this? There is no way to access the 'Add external file' dialog tab without trying to pass a parameter.

Copy link

cloudflare-workers-and-pages bot commented Oct 9, 2024

Deploying opendataeditor with  Cloudflare Pages  Cloudflare Pages

Latest commit: ea49ee0
Status: ✅  Deploy successful!
Preview URL: https://8bb6ac5b.opendataeditor.pages.dev
Branch Preview URL: https://471-prototype-menu-ipc.opendataeditor.pages.dev

View logs

@roll
Copy link
Collaborator

roll commented Oct 10, 2024

@guergana
If you move selected tab logic to the store you will be able to control it outside of the FileUpload dialog:

 bridge?.onMenuAddNewFile(() => {
    setFileUploadTab('remote')
    openDialog('fileUpload')
  })

Or you can have to dialog names fileUploadLocal and fileUploadRemote that activate initial tabs accordingly

@guergana
Copy link
Collaborator Author

guergana commented Oct 10, 2024

@guergana If you move selected tab logic to the store you will be able to control it outside of the FileUpload dialog:

 bridge?.onMenuAddNewFile(() => {
    setFileUploadTab('remote')
    openDialog('fileUpload')
  })

Or you can have to dialog names fileUploadLocal and fileUploadRemote that activate initial tabs accordingly

Thanks, @roll . I've found another way. It works like a charm!!!!

@guergana guergana changed the title [WiP] Add top menu to app Add top menu to app Oct 13, 2024
Copy link
Collaborator

@roll roll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I tested it works good aside one typo making errors/source to collide

client/store/actions/app.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@romicolman romicolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I testes it on Mac.

File menu: when I first select Add and then New file, it works OK. However, when I go to the file menu and then select Add + New folder or External data, it does not work (the add data dialog does not pop-up).

Something similar occurs with the View menu. If you select a file from the left menu of the ODE and then you click on View--Metadata, Errors panel or Source it does not work.

The Help menu works OK.

@guergana guergana requested a review from roll October 14, 2024 14:19
Copy link
Collaborator

@romicolman romicolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested PR 471. It works OK.

@guergana
Copy link
Collaborator Author

guergana commented Oct 18, 2024

Thanks! I tested it works good aside one typo making errors/source to collide

@roll the PR is ready for review again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ODE - Top menu options
3 participants