Feature/add merkle proof sdk #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 16, 2024 15:42
cliff0412
reviewed
Aug 19, 2024
cliff0412
reviewed
Aug 19, 2024
cliff0412
reviewed
Aug 19, 2024
cliff0412
reviewed
Aug 19, 2024
RUAN0007
reviewed
Aug 19, 2024
| @@ -19,17 +40,17 @@ impl MerkleProofIndex { | |||
|
|
|||
| /// Get the siblings index for the merkle proof of inclusion given a leaf index of a binary merkle sum tree. | |||
| /// We get the parent index of a leaf using the formula: parent = index / 2 + num_leaves | |||
| pub fn get_mst_siblings_index(global_index: usize, global_mst: &GlobalMst) -> Vec<usize> { | |||
| pub fn get_mst_siblings_index(global_index: usize, cfg: &GlobalConfig) -> Vec<usize> { | |||
There was a problem hiding this comment.
shall we make this function as a method in Global_MST?
There was a problem hiding this comment.
I think so too, but I dont want to load the global MST, it is heavy because it contains an entire vector of all the hashes, we can probably refactor the global MST struct instead.
There was a problem hiding this comment.
I think so too, but I dont want to load the global MST, it is heavy because it contains an entire vector of all the hashes, we can probably refactor the global MST struct instead.
agree
…/proof-of-reserves-v2 into feature/add-merkle-proof-sdk
cliff0412
reviewed
Aug 19, 2024
added 2 commits
August 19, 2024 16:28
…/proof-of-reserves-v2 into feature/add-merkle-proof-sdk
|
pass root as parameter in verify |
|
the raw account format should be the readable json data rather than a vector |
cliff0412
approved these changes
Aug 19, 2024
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a CLI command to fetch the merkle proof for a given user index.