Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove exception branches from coverage #7

Merged
merged 1 commit into from
Dec 25, 2023

Conversation

oliverlee
Copy link
Owner

@oliverlee oliverlee commented Dec 24, 2023

Disable exceptions to reduce "hidden branches" analyzed by gcov. These
branches are not a realistic indicator of coverage as this library does
not explicitly allocate memory, throw exceptions, or catch exceptions.

Change-Id: I6df51846f4e3da70cc2d53b6e4e6e2b9be36a2f7

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a38877) 79.53% compared to head (0cf0a2e) 93.43%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #7       +/-   ##
===========================================
+ Coverage   79.53%   93.43%   +13.89%     
===========================================
  Files          14       14               
  Lines         259      259               
  Branches       61       28       -33     
===========================================
+ Hits          206      242       +36     
+ Misses          4        2        -2     
+ Partials       49       15       -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliverlee oliverlee force-pushed the I6df51846f4e3da70cc2d53b6e4e6e2b9be36a2f7 branch 4 times, most recently from 7832c40 to 337cd31 Compare December 24, 2023 08:49
@oliverlee oliverlee changed the title wip test cov use -fno-exceptions with gcov Dec 24, 2023
@oliverlee oliverlee force-pushed the I6df51846f4e3da70cc2d53b6e4e6e2b9be36a2f7 branch from 337cd31 to 730f0e4 Compare December 24, 2023 22:05
@oliverlee oliverlee changed the title use -fno-exceptions with gcov remove exception branches from coverage Dec 24, 2023
@oliverlee oliverlee changed the base branch from main to I0164e5752b4967ecad87c7fb7eee6622b847ab4b December 24, 2023 22:05
.github/codecov.yml Outdated Show resolved Hide resolved
@oliverlee oliverlee force-pushed the I0164e5752b4967ecad87c7fb7eee6622b847ab4b branch from 1c32be1 to f4a27ed Compare December 24, 2023 22:19
Base automatically changed from I0164e5752b4967ecad87c7fb7eee6622b847ab4b to main December 24, 2023 22:27
@oliverlee oliverlee force-pushed the I6df51846f4e3da70cc2d53b6e4e6e2b9be36a2f7 branch from 730f0e4 to d3496ec Compare December 24, 2023 22:32
@oliverlee oliverlee changed the base branch from main to Ie45398c4b048d35fc54ba7f6e76e3525dfbfe61c December 24, 2023 22:32
@oliverlee oliverlee force-pushed the Ie45398c4b048d35fc54ba7f6e76e3525dfbfe61c branch 6 times, most recently from 31d14d3 to ff6027e Compare December 24, 2023 23:48
@oliverlee oliverlee force-pushed the I6df51846f4e3da70cc2d53b6e4e6e2b9be36a2f7 branch from d3496ec to edb986a Compare December 24, 2023 23:48
Base automatically changed from Ie45398c4b048d35fc54ba7f6e76e3525dfbfe61c to main December 24, 2023 23:57
@oliverlee oliverlee force-pushed the I6df51846f4e3da70cc2d53b6e4e6e2b9be36a2f7 branch 2 times, most recently from 28bff73 to b82becd Compare December 24, 2023 23:58
@oliverlee oliverlee changed the base branch from main to Iab70b19402e159a244f864f1396930775eb3e542 December 24, 2023 23:58
Base automatically changed from Iab70b19402e159a244f864f1396930775eb3e542 to main December 25, 2023 00:31
@oliverlee oliverlee force-pushed the I6df51846f4e3da70cc2d53b6e4e6e2b9be36a2f7 branch from b82becd to ab3bb11 Compare December 25, 2023 00:31
Disable exceptions to reduce "hidden branches" analyzed by gcov. These
branches are not a realistic indicator of coverage as this library does
not explicitly allocate memory, throw exceptions, or catch exceptions.

Change-Id: I6df51846f4e3da70cc2d53b6e4e6e2b9be36a2f7
@oliverlee oliverlee force-pushed the I6df51846f4e3da70cc2d53b6e4e6e2b9be36a2f7 branch from ab3bb11 to 0cf0a2e Compare December 25, 2023 00:45
@oliverlee oliverlee enabled auto-merge (squash) December 25, 2023 00:45
@oliverlee oliverlee merged commit 5ebbea2 into main Dec 25, 2023
15 checks passed
@oliverlee oliverlee deleted the I6df51846f4e3da70cc2d53b6e4e6e2b9be36a2f7 branch December 25, 2023 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant