Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Metal arrays #31

Closed

Conversation

albert-de-montserrat
Copy link

No description provided.

Copy link
Owner

@omlins omlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Project.toml Outdated Show resolved Hide resolved
test/test_CellArray.jl Outdated Show resolved Hide resolved
test/test_CellArray.jl Outdated Show resolved Hide resolved
test/test_CellArray.jl Outdated Show resolved Hide resolved
test/test_CellArray.jl Outdated Show resolved Hide resolved
A.data.=3; @roc gridsize=size(A) matsquare2D_AMDGPU!(A); AMDGPU.synchronize(); @test all(Base.Array(A.data) .== 9)
J.data.=3; J_ref.data.=36; @roc gridsize=size(J) matsquare2D_AMDGPU!(J); AMDGPU.synchronize(); @test AMDGPU.@allowscalar all(J .== J_ref)
C.data.=2; G.data.=3; @roc gridsize=size(C) add2D_AMDGPU!(C, G); AMDGPU.synchronize(); @test all(Base.Array(C.data) .== 5)
A.data.=3; wait(@roc gridsize=size(A) matsquare2D_AMDGPU!(A)); @test all(Base.Array(A.data) .== 9)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we not just change it the other way round? To be checked...

Copy link
Owner

@omlins omlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small addition

test/test_CellArray.jl Outdated Show resolved Hide resolved
test/test_CellArray.jl Outdated Show resolved Hide resolved
test/test_CellArray.jl Show resolved Hide resolved
@omlins
Copy link
Owner

omlins commented Oct 14, 2024

solved in #40

@omlins omlins closed this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants