Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent timing attack on CSRF #123

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

eutopian
Copy link

use secure_compare instead of plain equality comparison on request and callback state to prevent timing attacks.

@eutopian eutopian force-pushed the master branch 5 times, most recently from b547a44 to 1517196 Compare November 14, 2018 23:43
@tmilewski
Copy link
Member

Hey! Would you mind rebasing on master and removing all rubocop specific updates? I'll merge this in once that's complete. Thanks!

@eutopian
Copy link
Author

@tmilewski Hi! Just did that, thanks!

@tmilewski
Copy link
Member

tmilewski commented Dec 20, 2018 via email

@BobbyMcWho
Copy link
Member

Closing and reopening to trigger CI

@BobbyMcWho BobbyMcWho closed this Jan 12, 2021
@BobbyMcWho BobbyMcWho reopened this Jan 12, 2021
@@ -87,6 +87,16 @@ def app
instance.callback_phase
end
end

describe "#secure_params" do

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
describe "#secure_params" do
describe "#secure_compare" do

@jhartzler
Copy link

jhartzler commented Sep 27, 2023

I don't have permission to write to this fork but was wondering if it's possible to get this PR over the line (or the new PR I just opened which resolves the merge conflicts and spec rename) to fix an outstanding security vuln that's also affecting omniauth-auth0 downstream
I didn't find a CONTRIBUTING.md but would love more information on contributing if it would help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants