Ensured the print buffer is flushed before program exit, short printing #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpp
force-pushed
the
dpp_short_and_syncy
branch
from
3fe0f77
to
22af5dc
Compare
|
Thanks! Maybe instead of a new flag for short output, we could have an additional format option. So there’s:
|
|
Should I update the PR? |
|
Yeah I think so. Should be pretty easy to change to modify the format enum instead. |
|
LGTM! I think you’re just hitting the conventional commit checker on CI. Rebasing to edit the commit messages to be prefixed with a conventional commit standard prefix should work. I’d probably use “feat:” |
dpp
force-pushed
the
dpp_short_and_syncy
branch
from
d0bf2d7
to
761124f
Compare
Added a new 'Short' format that only prints the gitoid Signed-off-by: David Pollak <feeder.of.the.bears@gmail.com>
dpp
force-pushed
the
dpp_short_and_syncy
branch
from
761124f
to
db8a027
Compare
|
@alilleybrinker Ready to merge. Please do the honors. |
|
Thanks @dpp! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added an option to only print the gitoid in "plain" output mode so that it can be passed directly to
curlor otherwise be used in CLI applications.Also, ensured the print buffer (an async thread) has completed outputting before the program is terminated. This addressed a bug when using
curl https://goatrodeo.org/omnibor/$(omnibor id ...)Related Issue
Okay... I'm being bad. I didn't create an issue.
Motivation and Context
Make the tool CLI friendly
How Has This Been Tested?
Smoke test