Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix p2p sync bugs #50

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Fix p2p sync bugs #50

wants to merge 9 commits into from

Conversation

ekigamba
Copy link
Contributor

@ekigamba ekigamba commented Sep 16, 2022

IMPORTANT: Where possible all PRs must be linked to a Github issue

Fixes #1280

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Release | Other)

Checklist

  • I have written Unit tests for any new feature(s) and edge cases for bug fixes
  • I have added any strings visible on UI components to the strings.xml file
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the project's style guide

- Disconnect from wifi-direct when closing the activity
- Disconnect from wifi-direct before starting searching if the devices is already in a wifi-direct group
@ekigamba
Copy link
Contributor Author

Replicated issues

  1. Failing connection if p2p had previously connected or the devices were previously connected and then a new p2p connection is attempted. This could be due to the application being closed without correctly disconnecting
  2. Wifi-direct disconnection on one device while the other device holds the connection

@Rkareko
Copy link
Contributor

Rkareko commented Nov 25, 2022

Replicated issues

  1. Failing connection if p2p had previously connected or the devices were previously connected and then a new p2p connection is attempted. This could be due to the application being closed without correctly disconnecting
  2. Wifi-direct disconnection on one device while the other device holds the connection

@ekigamba These issues appear to have been fixed by the changes made on the P2P UI/UX enhancements PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[P2P] - Sync bugs on latest release v.0.0.6
2 participants