Fix pm2-process restart error #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
peterMuriuki
commented
Sep 7, 2020
•
peterMuriuki
commented
- use weareinteractive.pm2 role to install and configure pm2 processes
- Test using podman
peterMuriuki
force-pushed
the
fix-pm2
branch
from
1ef616e
to
4f29a79
Compare
It can be really stressful dealing with docker when you want to containerize a service that makes use of systemd
Somehow this way when the handler service start task runs it does not fail
peterMuriuki
changed the title
peterMuriuki
requested review from
ukanga,
ciremusyoka,
evansmurithi,
jasonrogena,
morrismukiri and
moshthepitt
|
created issue to look at idempotence and linting here: #13 |
|
what is causing the test to fail? |
This reverts commit cbb776d.
moshthepitt
reviewed
Oct 2, 2020
tasks/configure.yml
Outdated
| ignore_errors: true | ||
| tags: | ||
| - molecule-idempotence-notest # noqa 301 | ||
| - name: pm2 configure |
There was a problem hiding this comment.
some of the envs that should be passed are outputs of havin run some tasks for example. pm2 start command needs to be passed the path where the index file is, the index file is an output of running build.
The problem is that I understand dependencies will run before the role actually executes.
Forced due to reason that ll containers running on github actions run on systemd-unsupported docker containers
Make it possible to deploy several apps to the same host
ukanga
reviewed
Feb 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.