Delete data on FHIR #104
Closed
Delete data on FHIR #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes ##101
pld
reviewed
Jan 10, 2024
| @CommandLine.Option( | ||
| names = {"-id", "--identifiers"}, | ||
| description = "Resource Identifiers if deleting a single resource", | ||
| required = true) |
There was a problem hiding this comment.
this is required, but the description makes it sound like it is optional
Wambere
reviewed
Jan 11, 2024
|
|
||
| @Override | ||
| public void run() { | ||
| String url = baseUrl + "/" + resourceType + "?_id=" + identifiers + "&_cascade=delete"; |
There was a problem hiding this comment.
Can we make the cascades delete optional? maybe make it default not, considering the risk involved in data loss, so the person running the command has to actually opt in
|
Based on our conversation, closing this in favour of the cleaner scripts which are more robust and straight forward to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes [ https://github.com//issues/101 ]
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #[issue number] or Closes #[issue number]
Engineer Checklist
./gradlew spotlessApplyto check my code follows the project's style guide