Add support for importing inventory and products #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@dubdabasoduba please review the resources created for products and inventories here @pld @ukanga I'm going to use the other PR ( #178 ) for a proper refactor, just trying to unblock this here |
Wambere
changed the title
Wambere
force-pushed
the
157-import-inventory
branch
from
a647f81
to
1fc65e8
Compare
pld
reviewed
Apr 22, 2024
importer/main.py
Outdated
Comment on lines
735
to
736
| for x in reversed(del_indexes): | ||
| del payload_obj["resource"]["characteristic"][x] |
There was a problem hiding this comment.
think you can move this after the conditional, like to line 740
importer/main.py
Outdated
Comment on lines
630
to
631
| for x in reversed(del_indexes): | ||
| del payload_obj["resource"]["characteristic"][x] |
There was a problem hiding this comment.
can remove entirely if you move this or other one below the conditional
pld
approved these changes
Apr 30, 2024
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Part of #157
Built this branch off of #178 so it might look a bit more loaded
Engineer Checklist
./gradlew spotlessApplyto check my code follows the project's style guide