Handle deletion of inventory identifiers properly #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dubdabasoduba
approved these changes
Jul 10, 2024
hilpitome
pushed a commit
that referenced
this pull request
Jul 16, 2024
pld
pushed a commit
that referenced
this pull request
Jul 16, 2024
* init multifactor authentication setup * Revert "init multifactor authentication setup" This reverts commit 826f31a. * put translations in the same file if -tf is not given * deep copy config folder * copy over temp configs in happy path * create temp file when config points to single resource file * delete tmp files after translation * fix failing test * add test * test behavior for malformed json * change how properties file is read * put translations in the same file if -tf is not given * deep copy config folder * Add i18N support for new config fields * Update TransformSupportServices class to match FHIRCore * Refactor Versioning, remove Duplication * Release Version 2.3.6 🔖 * copy over temp configs in happy path * create temp file when config points to single resource file * delete tmp files after translation * fix failing test * add test * test behavior for malformed json * Handle deletion of inventory identifiers properly (#219) * Add product material number indentifier (#220) * Refactor i17N fix encoding bug 🐛 * Create List resource to reference product resources (#221) * Create List resource referencing Group and Binary resources created by product import * Add List resource json payload * Allow auto updating of the List resource * Add SM Tool readme file (#223) * change how properties file is read * Initial Commit (#224) --------- Co-authored-by: Martin Ndegwa <mndegwa@ona.io> Co-authored-by: Wambere <janette@wambere.com> Co-authored-by: Sharon Akinyi <79141719+sharon2719@users.noreply.github.com> Co-authored-by: Francis Odhiambo <4540684+f-odhiambo@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #216
Engineer Checklist
./gradlew spotlessApplyto check my code follows the project's style guide