Update how partOf is added to a location #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wambere
commented
Jul 23, 2024
| ).replace("$parentID", locationParentId) | ||
| if locationParentId and locationParentId != "parentId": | ||
| payload_string = payload_string.replace("$parentID", locationParentId) | ||
| if not locationParentName or locationParentName == "parentName": |
There was a problem hiding this comment.
Just mentioning here, that this implementation makes the assumption that if only the parentName is provided and the id is not provided, then it's okay to ignore it and remove the whole section
There was a problem hiding this comment.
Yes, this assumption is correct.
dubdabasoduba
approved these changes
Jul 23, 2024
Wambere
added a commit
that referenced
this pull request
Jul 29, 2024
Co-authored-by: Peter Muriuki <pmuriuki98@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #230
Also part of #210
Engineer Checklist
./gradlew spotlessApplyto check my code follows the project's style guide