Handle unsupported datatypes #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 28, 2024
pld
requested changes
Sep 3, 2024
There was a problem hiding this comment.
note that if we're trying to validate the resource content (which I don't see us doing here) we can use the HAPI validation libraries to do that, it might be worth using them here to validate the names, I'm not sure if they have a function to just validate that a resource name is an existing FHIR version, but probably, it seems like a feature they would need
sm-gen/src/main/kotlin/org.smartregister.fhir.structuremaptool/Main.kt
Outdated
Show resolved
Hide resolved
sm-gen/src/main/kotlin/org.smartregister.fhir.structuremaptool/Main.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Lentumunai-Mark <lentumunai.mark@students.jkuat.ac.ke> Co-authored-by: Peter Lubell-Doughtie <peter@ona.io>
Lentumunai-Mark
approved these changes
Oct 15, 2024
pld
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Where possible all PRs must be linked to a Github issue
Fixes #[issue number] or Closes #[issue number]
Engineer Checklist
./gradlew spotlessApplyto check my code follows the project's style guide