Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean fixes #284

Merged
merged 2 commits into from
Sep 3, 2024
Merged

clean fixes #284

merged 2 commits into from
Sep 3, 2024

Conversation

Wambere
Copy link
Contributor

@Wambere Wambere commented Sep 2, 2024 •
edited
Loading

IMPORTANT: Where possible all PRs must be linked to a Github issue

These came up after a debugging session, their purpose it to help make the code clearer

  1. Update docs to use .env instead of config
  2. Add some logs for clarity, to show why a user was not created if the request fails

@Wambere Wambere changed the title Update docs to use .env instead of config, and add some logs for clarity clean fixes Sep 2, 2024
@Wambere Wambere enabled auto-merge (squash) September 2, 2024 13:10
@Wambere Wambere merged commit 5543b8d into main Sep 3, 2024
4 checks passed
@Wambere Wambere deleted the improvements branch September 3, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pld pld pld approved these changes

@dubdabasoduba dubdabasoduba Awaiting requested review from dubdabasoduba

@Rkareko Rkareko Awaiting requested review from Rkareko

Assignees
No one assigned
Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wambere @pld