[DNM] Fix CI (#765)

* Fix eslint snap-linter

refer: https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-large-snapshots.md

https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/no-large-snapshots.md

* Refactor ci-flaky latitude-longitude validation test

* Revert eslint ecmaVersion

* Remove surplus lint command

.circleci/config.yml

@@ -38,7 +38,6 @@ jobs:
           name: Install dependencies
           command: yarn install
 
-      # TODO - why does the test fail without this.
       - run:
           name: build packages
           command: yarn lerna:prepublish
@@ -49,13 +48,9 @@ jobs:
           key: v1-dependencies-{{ checksum "package.json" }}
 
       - run:
-          name: Run ts linter
+          name: Run linter
           command: yarn lint
 
-      - run:
-          name: Run snap linter
-          command: yarn lint-snap --debug
-
       - run:
           name: Run test with coverage
           command: yarn test --verbose --collectCoverage=true --forceExit --detectOpenHandles

package.json

@@ -10,8 +10,7 @@
     "lerna:publish": "yarn install && yarn run lerna:prepublish && lerna publish from-package --ignore-scripts --ignore-prepublish",
     "test": "TZ='UTC' jest",
     "test:watch": "TZ='UTC' jest --watch",
-    "lint": "eslint {packages,app}/**/*.{js,ts,tsx} --max-warnings 0",
-    "lint-snap": "eslint {packages,app}/**/*.snap"
+    "lint": "eslint {packages,app}/**/*.{js,ts,tsx} --max-warnings 0"
   },
   "jest": {
     "setupFiles": [

packages/location-management/src/components/LocationForm/tests/index.test.tsx

@@ -210,13 +210,12 @@ describe('LocationForm', () => {
       wrapper.update();
     });
 
-    expect(wrapper.find('FormItem#longitude').text()).toMatchInlineSnapshot(
-      `"LongitudeOnly decimal values allowed"`
-    );
-
-    expect(wrapper.find('FormItem#latitude').text()).toMatchInlineSnapshot(
-      `"LatitudeOnly decimal values allowed"`
-    );
+    expect(wrapper.find('FormItemInput#longitude').prop('errors')).toEqual([
+      'Only decimal values allowed',
+    ]);
+    expect(wrapper.find('FormItemInput#latitude').prop('errors')).toEqual([
+      'Only decimal values allowed',
+    ]);
 
     wrapper.unmount();
   });