Editing local.json file need not break app

onaio · Jan 23, 2023 · efaae2e · efaae2e
1 parent 7947d40
commit efaae2e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/apps/web/src/lib/server/appConfig/utils.ts b/apps/web/src/lib/server/appConfig/utils.ts
@@ -4,22 +4,22 @@ import { basename } from 'node:path';
 import { allSymbolConfigsAccessor } from '$lib/server/constants';
 
 export const getConfig = (key: string, defualt?: unknown, getFromDefaultToo = true) => {
-	const config: IConfig = importFresh('config');
+	try {
+		const config: IConfig = importFresh('config');
 
-	const sources = config.util.getConfigSources();
-	const localSource = sources.filter((source) => basename(source.name) === 'local.json')[0];
+		const sources = config.util.getConfigSources();
+		const localSource = sources.filter((source) => basename(source.name) === 'local.json')[0];
 
-	// if only default then return default
-	if (!getFromDefaultToo) {
-		if (localSource?.parsed[allSymbolConfigsAccessor] === undefined) {
-			if (defualt !== undefined) {
-				return defualt;
-			} else {
-				throw new Error(`${key} was not found in the ${localSource.name}`);
+		// if only default then return default
+		if (!getFromDefaultToo) {
+			if (localSource?.parsed[allSymbolConfigsAccessor] === undefined) {
+				if (defualt !== undefined) {
+					return defualt;
+				} else {
+					throw new Error(`${key} was not found in the ${localSource.name}`);
+				}
 			}
 		}
-	}
-	try {
 		const value = config.get(key);
 		return value;
 	} catch (err) {

diff --git a/packages/core/src/evaluator/pipelinesController.ts b/packages/core/src/evaluator/pipelinesController.ts
@@ -83,7 +83,9 @@ export class PipelinesController {
     }
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
     for (const [uuid, _] of Object.entries(existingPipelinesCounter)) {
+      this.stopScheduledEvaluations(uuid);
       delete this.pipelines[uuid];
+      delete this.tasks[uuid];
     }
   }