cast create Entity request data to string

onaio · Aug 27, 2024 · d2466f0 · d2466f0
1 parent 2b7a611
commit d2466f0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/onadata/apps/api/tests/viewsets/test_entity_list_viewset.py b/onadata/apps/api/tests/viewsets/test_entity_list_viewset.py
@@ -960,7 +960,7 @@ def test_create_entity(self, mock_now):
             "label": "30cm mora",
             "geometry": "-1.286805 36.772845 0 0",
             "species": "mora",
-            "circumference_cm": 30,
+            "circumference_cm": "30",
         }
         self.assertEqual(
             response.data,
@@ -1157,7 +1157,7 @@ def test_updating_entity(self, mock_now):
         expected_json = {
             "geometry": "-1.286805 36.772845 0 0",
             "species": "mora",
-            "circumference_cm": 30,
+            "circumference_cm": "30",
             "label": "30cm mora",
         }
 

diff --git a/onadata/libs/serializers/entity_serializer.py b/onadata/libs/serializers/entity_serializer.py
@@ -180,7 +180,7 @@ class EntitySerializer(serializers.ModelSerializer):
     data = serializers.JSONField(write_only=True, required=False)
 
     def validate_data(self, value):
-        """Validate `data` field"""
+        """Validate and cast `data` field values to strings"""
         allowed_properties = set(self.context["entity_list"].properties)
         invalid_properties = [
             key for key in value.keys() if key not in allowed_properties
@@ -195,6 +195,9 @@ def validate_data(self, value):
                 )
             )
 
+        # Cast all data field values to strings
+        value = {key: str(val) for key, val in value.items()}
+
         return value
 
     def validate(self, attrs):