Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for creating Entity via API #2683

Merged
merged 18 commits into from
Sep 12, 2024
Merged

Conversation

kelvin-muchiri
Copy link
Contributor

@kelvin-muchiri kelvin-muchiri commented Aug 27, 2024

Changes / Features implemented

Add support for creating Entity via API: POST /api/v2/entity-lists/<id>/entities

Steps taken to verify this change does what is intended

  • QA
  • Added tests

Before submitting this PR for review, please make sure you have:

  • Included tests
  • Updated documentation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kelvin-muchiri What happens if you create the exact same entity twice - specifically when the UUID is from the client side vs when the UUID is missing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add the UUID to be unique per Entity List

@kelvin-muchiri kelvin-muchiri force-pushed the create-entity-endpoint branch 2 times, most recently from 521bd50 to ad27fb3 Compare September 4, 2024 14:06
@faith-mutua
Copy link

@kelvin-muchiri this has been implemented and is working as expected

Screenshot from 2024-09-05 17-44-09

@kelvin-muchiri kelvin-muchiri merged commit c078046 into main Sep 12, 2024
10 checks passed
@kelvin-muchiri kelvin-muchiri deleted the create-entity-endpoint branch September 12, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants