Add organization email to organization profile instead of adding to organization user #2712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankApiyo
force-pushed
the
use-email-provided-when-creating-organization-to-set-metadata
branch
from
b0caa18
to
a8c0a66
Compare
FrankApiyo
changed the title
ukanga
previously approved these changes
Oct 1, 2024
FrankApiyo
force-pushed
the
use-email-provided-when-creating-organization-to-set-metadata
branch
2 times, most recently
from
9459ed1
to
1dfcd5d
Compare
kelvin-muchiri
requested changes
Oct 2, 2024
| @@ -186,7 +187,7 @@ def save(self, *args, **kwargs): # pylint: disable=arguments-differ | |||
| @property | |||
| def email(self): | |||
| "organization email" | |||
| return self.user.email | |||
| return self.organization_email | |||
There was a problem hiding this comment.
@FrankApiyo Would it have been easier to have the field email instead and get rid of the email property?
ukanga
approved these changes
Oct 2, 2024
kelvin-muchiri
approved these changes
Oct 3, 2024
FrankApiyo
deleted the
use-email-provided-when-creating-organization-to-set-metadata
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
Add organization email to organization profile instead of adding to organization user
Steps taken to verify this change does what is intended
Updated test cases
Side effects of implementing this change
N/A
Before submitting this PR for review, please make sure you have:
Closes #2714