Skip to content

Commit

Permalink
changes for 18.9.0 release
Browse files Browse the repository at this point in the history
  • Loading branch information
J. Doe (https://devcenter.bitrise.io/builds/setting-your-git-credentials-on-build-machines/) committed Oct 26, 2020
1 parent 2999735 commit f1c9ad0
Show file tree
Hide file tree
Showing 11 changed files with 209 additions and 25 deletions.
24 changes: 24 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,30 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

**Note**: If the strings translations change it will result in a MINOR version change, therefore you are responsible for testing your translated layout in case you are using custom translations. [More on language localisation](README.md#language-customisation)

## [18.9.0] - 2020-10-23

### Added

- Public: Added ability to skip selfie intro.
- UI: User can now enlarge capture document for detailed inspection

### Changed

- UI: Changed text and background colors in light mode
- Public: Now sharing Onfido license files in github repository along with SDK bundle
- UI: Changed Onfido logo position in capture screens
- UI: Changed Onfido logo position in intro and permission screens
- UI: Added Onfido logo to the document type selection screen
- Public: Removed unused strings from localisation
- Public: Renamed some generic keys
- UI: Changed bubble view position and apperance for document capture flow
- Public: Now disabling passport autocapture on simulators

### Fixed

- UI: Now showing wrong side head turn warning again
- UI: Fixed the incorrect captured document positon on confirmation screen for multi format document types

## [18.8.1] - 2020-10-22

### Fixed
Expand Down
37 changes: 22 additions & 15 deletions Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,8 @@
"onfido_doc_capture_frame_accessibility" = "View from camera";
"onfido_selfie_capture_frame_accessibility" = "View from selfie camera";
"onfido_video_capture_frame_accessibility" = "View from selfie camera";
"onfido_doc_confirmation_image_accessibility" = "Photo of your document";
"Photo of your document. Double tap to enlarge.";
"onfido_selfie_confirmation_image_accessibility" = "Photo of your face";
"onfido_accessibility_liveness_confirmation_view" = "Your video";
"onfido_video_capture_frame_success_accessibility" = "Face detected";
/* Accessibility strings for screen readers */
"onfido_video_intro_video_accessibility" = "To record a selfie video, face the front camera and keep your phone slightly away from your face. You'll then need to recite some numbers and turn your head according to the instructions on screen.";
Expand All @@ -31,14 +30,20 @@
"onfido_doc_confirmation_button_primary_generic" = "Upload photo";
"onfido_doc_confirmation_button_primary_id" = "Upload photo";
/* Face/Document Confirmation */

"onfido_confirm_passport" = "Upload photo";
"onfido_confirm_residence_permit" = "Upload photo";
"onfido_confirm_visa" = "Upload photo";
"onfido_selfie_confirmation_confirm_button" = "Upload photo";
"onfido_selfie_confirmation_retake_button" = "Retake photo";
"onfido_doc_confirmation_button_primary_passport" = "Upload photo";
"onfido_doc_confirmation_button_primary_permit" = "Upload photo";
"onfido_doc_confirmation_button_primary_visa" = "Upload photo";
"onfido_selfie_confirmation_button_primary" = "Upload photo";
"onfido_selfie_confirmation_button_secondary" = "Retake photo";

/* Country Selection Screen */
"onfido_country_select_title" = "Select issuing country";
"onfido_decline" = "Decline";
"onfido_permission_button_primary_both" = "Enable both";
"onfido_permission_button_primary_cam" = "Enable camera";
"onfido_permission_button_primary_mic" = "Enable microphone";
Expand All @@ -65,7 +70,7 @@
"onfido_doc_select_button_permit" = "Residence permit";
"onfido_error_connection_message" = "There was a network error. Please check your connection.";
/* Network error */
"onfido_error_dialog_title" = "Connection lost";
"onfido_generic_alert_network_error_label" = "Connection lost";
"onfido_doc_capture_alert_no_face_detail" = "Make sure your face is visible";
"onfido_doc_capture_alert_no_face_detail_folded_doc" = "Lay your document flat to show the inside pages containing your photo";
"onfido_doc_capture_alert_no_face_title" = "Face not detected";
Expand All @@ -87,12 +92,9 @@
/* Folded paper document capture */
"onfido_app_title_doc_capture_id_it" = "Italian identity card";
"onfido_app_title_doc_capture_id_za" = "South African identity card";
"onfido_label_doc_type_driving_license_up" = "Driver's License";
"onfido_doc_select_button_generic" = "Document";
"onfido_label_doc_type_id_card_up" = "National Identity Card";
/* Document Types */
"onfido_label_doc_type_passport_up" = "Passport";
"onfido_label_doc_type_residence_permit_up" = "Residence Permit Card";
"onfido_doc_select_button_visa" = "Visa";
"onfido_doc_select_button_permit_work" = "Work Permit";
"onfido_video_capture_header_challenge_digit_instructions" = "Say each digit out loud";
Expand All @@ -107,11 +109,9 @@
"onfido_video_intro_list_item_move_speak" = "Finish actions in under %d seconds";
/* Liveness */
"onfido_video_intro_subtitle" = "For security, we need a live capture";
"onfido_message_capture_face" = "Position your face in the oval";
/* Liveness intro */
"onfido_video_intro_title" = "Record a video";
"onfido_video_intro_button_primary" = "Record video";
"onfido_liveness_preparation_subtitle" = "Press the record button and follow the instructions";
"onfido_video_capture_prompt_detail_timeout" = "Remember to press \"stop\" when you're done";
"onfido_video_capture_prompt_header_timeout" = "Looks like you took too long";
/* Locale identifier */
Expand All @@ -122,10 +122,13 @@
"onfido_doc_confirmation_body_license" = "Make sure your details are clear and unobstructed";
"onfido_doc_confirmation_body_generic" = "Make sure your details are clear and unobstructed";
"onfido_doc_confirmation_body_id" = "Make sure your details are clear and unobstructed";

/* Document capture confirmation */

"onfido_doc_confirmation_body_passport" = "Make sure your details are clear and unobstructed";
"onfido_doc_confirmation_body_permit" = "Make sure your details are clear and unobstructed";
"onfido_doc_confirmation_body_visa" = "Make sure your details are clear and unobstructed";

/* Face capture confirmation */
"onfido_selfie_confirmation_body" = "Make sure your entire face is visible";
"onfido_doc_capture_detail_license_back" = "Back";
Expand Down Expand Up @@ -153,7 +156,7 @@
"onfido_doc_capture_header_generic_front" = "Document";
"onfido_doc_capture_header_id_front" = "Identity card";
"onfido_doc_capture_header_permit_front" = "Residence permit";
"onfido_message_uploading" = "Uploading";
"onfido_generic_uploading" = "Uploading";
"onfido_doc_confirmation_alert_no_doc_detail" = "Make sure all the document is in the photo";
"onfido_selfie_confirmation_alert_no_face_detail" = "Make sure your face is fully visible";
"onfido_selfie_confirmation_alert_multiple_faces_detail" = "Only your face can be in the selfie";
Expand All @@ -167,15 +170,15 @@
"onfido_doc_confirmation_alert_no_doc_title" = "No document found";
/* Face error */
"onfido_selfie_confirmation_alert_no_face_title" = "No face found";
"onfido_ok" = "OK";
"onfido_orientation_message_subtitile_ios" = "We support portrait mode only";
"onfido_orientation_message_title_ios" = "Please rotate your iPad";
"onfido_orientation_upsidedown_message_ios" = "The button should be at the bottom of the screen";
"onfido_generic_alert_network_error_button_primary" = "OK";
"onfido_info_tablet_orientation_subtitle" = "We support portrait mode only";
"onfido_info_tablet_orientation_title" = "Please rotate your iPad";
"onfido_info_tablet_orientation_body" = "The button should be at the bottom of the screen";
"onfido_doc_capture_prompt_button_card" = "Plastic card";
"onfido_reload" = "Reload";
"onfido_doc_confirmation_button_secondary" = "Retake photo";
"onfido_video_confirmation_button_secondary" = "Retake video";
"onfido_retry" = "Retry";
"onfido_video_capture_prompt_button_timeout" = "Retry";
"onfido_country_select_bottom_sheet_link_doc_select" = "Select another document";
"onfido_welcome_button_primary" = "Start";
"onfido_video_capture_button_primary_start" = "Start recording";
Expand Down Expand Up @@ -226,3 +229,7 @@
"onfido_nfc_intro_sheet_header_ready" = "Lay your phone on your closed passport";
"onfido_nfc_intro_sheet_header_scanning" = "Scanning...";

"onfido_doc_confirmation_zoom_button" = "Enlarge image";
"onfido_doc_confirmation_image_accessibility" = "Photo of your document. Double tap to enlarge.";
"onfido_doc_zoom_body" = "Move around using one finger";
"onfido_doc_zoom_button_close" = "Close";
62 changes: 62 additions & 0 deletions MIGRATION.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

These guides below are provided to ease the transition of existing applications using the Onfido SDK from one version to another that introduces breaking API changes.

* [Onfido iOS SDK 18.9.0 Migration Guide](#onfido-ios-sdk-1890-migration-guide)
* [Onfido iOS SDK 18.8.0 Migration Guide](#onfido-ios-sdk-1880-migration-guide)
* [Onfido iOS SDK 18.7.0 Migration Guide](#onfido-ios-sdk-1870-migration-guide)
* [Onfido iOS SDK 18.5.0 Migration Guide](#onfido-ios-sdk-1850-migration-guide)
Expand Down Expand Up @@ -42,6 +43,67 @@ These guides below are provided to ease the transition of existing applications
* [Onfido iOS SDK 3.0.0 Migration Guide](#onfido-sdk-300-migration-guide)


## Onfido iOS SDK 18.9.0 Migration Guide

### String Changes

#### Added

The following string keys have been **added**:

- `onfido_capture_confirmation_image_zoom_instructions` (en, fr, es, de)

- `onfido_capture_confirmation_image_zoom_button` (en, fr, es, de)

- `onfido_capture_confirmation_image_preview_button` (en, fr, es, de)


- `onfido_generic_alert_network_error_label` (en, fr, de, es)

- `onfido_generic_uploading` (en, fr, de, es)

- `onfido_generic_alert_network_error_button_primary` (en, fr, de, es)

- `onfido_info_tablet_orientation_subtitle` (en, fr, de, es)

- `onfido_info_tablet_orientation_title` (en, fr, de, es)

- `onfido_info_tablet_orientation_body` (en, fr, de, es)


#### Removed

The following string keys have been **removed**:

- `onfido_accessibility_liveness_confirmation_view` (en, fr, de, es)

- `onfido_decline` (en, fr, de, es)

- `onfido_label_doc_type_driving_license_up` (en, fr, de, es)

- `onfido_label_doc_type_id_card_up` (en, fr, de, es)

- `onfido_label_doc_type_residence_permit_up` (en, fr, de, es)

- `onfido_message_capture_face` (en, fr, de, es)

- `onfido_liveness_preparation_subtitle` (en, fr, de, es)


- `onfido_error_dialog_title` (en, fr, de, es)

- `onfido_message_uploading` (en, fr, de, es)

- `onfido_ok` (en, fr, de, es)

- `onfido_orientation_message_subtitile_ios` (en, fr, de, es)

- `onfido_orientation_message_title_ios` (en, fr, de, es)

- `onfido_orientation_upsidedown_message_ios` (en, fr, de, es)



## Onfido iOS SDK 18.8.0 Migration Guide

### String Changes
Expand Down
12 changes: 5 additions & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -610,20 +610,18 @@ To configure with photo variant:
```
NSError * error;
Builder * variantBuilder = [ONFaceStepVariantConfig builder];
[variantBuilder withPhotoCaptureWithConfig: NULL];
[variantBuilder withPhotoCaptureWithConfig: [[PhotoStepConfiguration alloc] initWithShowSelfieIntroScreen: YES]]];
[configBuilder withFaceStepOfVariant: [variantBuilder buildAndReturnError: &error]];
```
#### Swift
```swift
let config = try! OnfidoConfig.builder()
.withSDKToken("YOUR_SDK_TOKEN_HERE")
.withWelcomeStep()
.withDocumentStep()
.withFaceStep(ofVariant: .photo(withConfiguration: nil)) // specify the face capture variant here
.withFaceStep(ofVariant: .photo(withConfiguration: PhotoStepConfiguration(showSelfieIntroScreen: true))) // specify the face capture variant here
.build()
```

Expand Down Expand Up @@ -1039,8 +1037,8 @@ A few things to check before you go live:

| User iOS Version | SDK Size Impact (MB) |
|------------------|-----------------------------------|
| 12.2 and above | 4.707|
| Below 12.2 | up to 4.707* or up to 16.407**|
| 12.2 and above | 4.741|
| Below 12.2 | up to 4.741* or up to 16.367**|


**\*** If the application is in Swift but doesn't include any Swift libraries that Onfido iOS SDK requires
Expand Down Expand Up @@ -1130,7 +1128,7 @@ Refer to our [accessibility statement](https://developers.onfido.com/guide/sdk-a
## Licensing
Due to API-design constraints, and to avoid possible conflicts during the integration, we bundle some of our 3rd party dependencies. For those, we include the licensing information inside our bundle, with the file named `onfido_licenses.json`.
Due to API-design constraints, and to avoid possible conflicts during the integration, we bundle some of our 3rd party dependencies. For those, we include the licensing information inside our bundle and also in this repo under license folder, with the file named [onfido_licenses.json](license/onfido_licenses.json).
This file contains a summary of our bundled dependencies and all the licensing information required, including links to the relevant license texts contained in the same folder.
Integrators of our library are then responsible for keeping this information along with their integrations.
Expand Down
4 changes: 3 additions & 1 deletion SampleApp/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '10.0'
target 'SampleApp' do
use_frameworks!
inhibit_all_warnings!

pod 'Onfido', '18.8.1'
pod 'Onfido', '18.9.0'
end

post_install do |installer|
Expand All @@ -12,6 +13,7 @@ post_install do |installer|
config.build_settings['EXPANDED_CODE_SIGN_IDENTITY'] = ""
config.build_settings['CODE_SIGNING_REQUIRED'] = "NO"
config.build_settings['CODE_SIGNING_ALLOWED'] = "NO"
config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = 10.0
end
end
end
4 changes: 3 additions & 1 deletion SampleAppObjC/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ source 'https://github.com/CocoaPods/Specs.git'
platform :ios, '10.0'
target 'SampleAppObjC' do
use_frameworks!
inhibit_all_warnings!

pod 'Onfido', '18.8.1'
pod 'Onfido', '18.9.0'
end

post_install do |installer|
Expand All @@ -12,6 +13,7 @@ post_install do |installer|
config.build_settings['EXPANDED_CODE_SIGN_IDENTITY'] = ""
config.build_settings['CODE_SIGNING_REQUIRED'] = "NO"
config.build_settings['CODE_SIGNING_ALLOWED'] = "NO"
config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = 10.0
end
end
end
File renamed without changes.
46 changes: 46 additions & 0 deletions license/onfido_licenses.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
{
"dependencies": [
{
"name": "Swinject",
"project_url": "https://github.com/Swinject/Swinject",
"license_name": "MIT",
"copyright_notice": "Copyright (c) 2015 Swinject Contributors",
"changed_source_code": false,
"source_code_changes": null
},
{
"name": "analytics-ios",
"project_url": "https://github.com/segmentio/analytics-ios",
"license_name": "MIT",
"copyright_notice": "Copyright (c) 2016 Segment.io, Inc.",
"changed_source_code": false,
"source_code_changes": null
},
{
"name": "MBProgressHUD",
"project_url": "https://github.com/matej/MBProgressHUD",
"license_name": "MIT",
"copyright_notice": "Copyright © 2009-2016 Matej Bukovinski",
"changed_source_code": true,
"source_code_changes": "renamed classes, variables and functions due to namespacing issues"
},
{
"name": "Open CV",
"project_url": "https://sourceforge.net/projects/opencvlibrary/files/3.4.5/opencv-3.4.5-ios-framework.zip/download",
"license_name": "3-clause BSD License",
"copyright_notice": "Copyright (C) 2015-2016, OpenCV Foundation",
"changed_source_code": false,
"source_code_changes": null
}
],
"licenses": [
{
"name": "MIT",
"file": "onfido_licenses_mit.txt"
},
{
"name": "3-clause BSD License",
"file": "onfido_licenses_3_clause_bsd.txt"
}
]
}
12 changes: 12 additions & 0 deletions license/onfido_licenses_3_clause_bsd.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
The 3-Clause BSD License

License Agreement
Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

1. Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer.

2. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.

3. Neither the name of the copyright holder nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission.

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this software, even if advised of the possibility of such damage.
30 changes: 30 additions & 0 deletions license/onfido_licenses_mit.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
WWWWWW||WWWWWW
W W W||W W W
||
( OO )__________
/ | \
/o o| MIT \
\___/||_||__||_|| *
|| || || ||
_||_|| _||_||
(__|__|(__|__|

The MIT License (MIT)

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
Loading

0 comments on commit f1c9ad0

Please sign in to comment.