Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move subdirectories under runtime to top level #3620

Merged
merged 5 commits into from
Oct 18, 2024
Merged

Move subdirectories under runtime to top level #3620

merged 5 commits into from
Oct 18, 2024

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Oct 17, 2024

Work towards #526

Description

Move sub directories under ./interpreter/ to ./

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS self-assigned this Oct 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 17, 2024 •
edited
Loading

Cadence Benchstat comparison

This branch with compared with the base branch onflow:master commit dbf5351
The command for i in {1..N}; do go test ./... -run=XXX -bench=. -benchmem -shuffle=on; done was used.
Bench tests were run a total of 7 times on each branch.

Collapsed results for better readability

@SupunS SupunS added the Go API Breaking Change Breaks programs which use the Cadence repo as a Go dependency label Oct 17, 2024
@SupunS
Copy link
Member Author

SupunS commented Oct 17, 2024

The backward compatibility check fails, because now the package names on master is different than what the tool uses. This would get fixed for subsequent PRs once this PR is merged to master.

@SupunS SupunS marked this pull request as ready for review October 17, 2024 21:35
@SupunS SupunS changed the title Move subdirectories under 'interpreter' to top level Move subdirectories under 'runtime' to top level Oct 17, 2024
@SupunS SupunS changed the title Move subdirectories under 'runtime' to top level Move subdirectories under runtime to top level Oct 17, 2024
turbolent
turbolent approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@SupunS SupunS merged commit 8b904c2 into master Oct 18, 2024
8 of 12 checks passed
@SupunS SupunS deleted the supun/restructure branch October 18, 2024 16:10
@BrewTestBot BrewTestBot mentioned this pull request Oct 18, 2024
Merged
@SupunS SupunS mentioned this pull request Oct 18, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turbolent turbolent turbolent approved these changes

Assignees

@SupunS SupunS

Labels
Go API Breaking Change Breaks programs which use the Cadence repo as a Go dependency Technical Debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SupunS @turbolent