Add random chance to panic mode for DependencyAudit #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| panic("This transaction is using dependencies not staged for Crescendo upgrade coming soon! Learn more: https://bit.ly/FLOWCRESCENDO. Dependencies not staged: ".concat(unstagedDependenciesString)) | ||
| } else { | ||
| emit UnstagedDependencies(dependencies: unstagedDependencies) | ||
| self.maybePanicOnUnstagedDependencies(unstagedDependencies) |
There was a problem hiding this comment.
I think I'm missing something - why do we want to randomly panic here? I would think we'd want clear expectations around whether unstaged dependencies panic or not.
There was a problem hiding this comment.
The business requirement is that there would be a random chance the transaction would fail if it is missing dependencies. That random chance would start at 0% and increase to 100% just before the spork.
There was a problem hiding this comment.
I see. I still don't understand the rationale behind that product decision, but not sure this is the place to discuss prod reqs so I'll just review based on that stated requirement
sisyphusSmiling
approved these changes
Jun 12, 2024
joshuahannan
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to set an end and start block between which the change of a transaction with unstaged dependencies panicking linearly increases.
For contributor use:
mainbranchFiles changedin the Github PR explorer