Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert updating to onflow/crypto@v0.24.9 for v0.41 branch #425

Merged
merged 2 commits into from
Jul 12, 2023

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Jul 12, 2023

Description

The purpose of this PR is to revert back to using the old crypto library for v0.41.* versions, so that downstream dependencies can keep using the sdk, without having to migrate to the new crypto library.
More details can be found on the discussion here: https://discord.com/channels/613813861610684416/1108968095982293002/1128441325960843305

This reverts commit 26fbdab for the v0.41 branch. Thus, all future releases from 0.41 branch will use the old crypto library.

The master branch will continue to use the new crypto library at onflow/crypto. Any releases from master branch can use versioning 0.42.*, and upwards.


For contributor use:

  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the standards mentioned here.
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@SupunS SupunS changed the title Revert updating to onflow/crypto@v0.24.9 for v0.41 branch Revert updating to onflow/crypto@v0.24.9 for v0.41 branch Jul 12, 2023
@SupunS SupunS mentioned this pull request Jul 12, 2023
6 tasks
@SupunS SupunS requested a review from Kay-Zee July 12, 2023 17:16
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2023

Codecov Report

Merging #425 (6c18d91) into v0.41 (aba1292) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            v0.41     #425   +/-   ##
=======================================
  Coverage   62.30%   62.30%           
=======================================
  Files          24       24           
  Lines        2966     2966           
=======================================
  Hits         1848     1848           
  Misses        994      994           
  Partials      124      124           
Flag Coverage Δ
unittests 62.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
crypto/crypto.go 27.18% <ø> (ø)
crypto/hash.go 0.00% <ø> (ø)
event.go 0.00% <ø> (ø)

@SupunS SupunS merged commit 08af36f into v0.41 Jul 12, 2023
1 check passed
@SupunS SupunS deleted the supun/revert-crypto-lib branch July 12, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants