Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetAccountBalance endpoint to grpc server #742

Conversation

illia-malachyn
Copy link
Contributor

Closes: #741

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 24.52830% with 120 lines in your changes missing coverage. Please review.

Project coverage is 51.03%. Comparing base (d91be5b) to head (6e6b594).
Report is 167 commits behind head on master.

Files with missing lines Patch % Lines
access/grpc/mocks/RPCClient.go 17.14% 106 Missing and 10 partials ⚠️
access/grpc/client.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #742       +/-   ##
===========================================
- Coverage   61.97%   51.03%   -10.94%     
===========================================
  Files          27       35        +8     
  Lines        3734     5410     +1676     
===========================================
+ Hits         2314     2761      +447     
- Misses       1231     2309     +1078     
- Partials      189      340      +151     
Flag Coverage Δ
unittests 51.03% <24.52%> (-10.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@illia-malachyn
Copy link
Contributor Author

@janezpodhostnik please, merge it in

@franklywatson franklywatson merged commit 356f7b7 into onflow:master Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GetAccountBalance* endpoints
5 participants