Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add get account keys endpoints #753

Merged

Conversation

illia-malachyn
Copy link
Contributor

Closes: #744

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 52.41%. Comparing base (b87f9c7) to head (8884ba7).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
access/grpc/client.go 0.00% 8 Missing ⚠️
access/grpc/convert/convert.go 0.00% 8 Missing ⚠️
access/grpc/grpc.go 81.81% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #753      +/-   ##
==========================================
+ Coverage   51.45%   52.41%   +0.96%     
==========================================
  Files          35       35              
  Lines        5446     5506      +60     
==========================================
+ Hits         2802     2886      +84     
+ Misses       2288     2240      -48     
- Partials      356      380      +24     
Flag Coverage Δ
unittests 52.41% <60.00%> (+0.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@illia-malachyn
Copy link
Contributor Author

@janezpodhostnik you can merge it

@franklywatson
Copy link
Contributor

Can merge once conflicts are resolved

auto-merge was automatically disabled September 18, 2024 09:48

Head branch was pushed to by a user without write access

@peterargue peterargue merged commit 423dc3a into onflow:master Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GetAccountKey* endpoints
6 participants