Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetFullCollectionById endpoint #754

Conversation

illia-malachyn
Copy link
Contributor

Closes: #748

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 31.57895% with 39 lines in your changes missing coverage. Please review.

Project coverage is 52.38%. Comparing base (f839f68) to head (c8d6c13).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
access/grpc/convert/convert.go 0.00% 16 Missing ⚠️
access/grpc/grpc.go 40.00% 11 Missing and 1 partial ⚠️
collection.go 0.00% 7 Missing ⚠️
access/grpc/client.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
+ Coverage   51.42%   52.38%   +0.95%     
==========================================
  Files          35       35              
  Lines        5499     5559      +60     
==========================================
+ Hits         2828     2912      +84     
+ Misses       2309     2261      -48     
- Partials      362      386      +24     
Flag Coverage Δ
unittests 52.38% <31.57%> (+0.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

access/client.go Outdated Show resolved Hide resolved
@franklywatson franklywatson merged commit 2689460 into onflow:master Sep 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add GetCollectionByID and GetFullCollectionByID endpoints
4 participants