Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SubscribeBlockHeaders* endpoints #760

Conversation

illia-malachyn
Copy link
Contributor

Part of #746

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 69.62025% with 24 lines in your changes missing coverage. Please review.

Project coverage is 54.83%. Comparing base (7b58582) to head (23fdfe2).
Report is 19 commits behind head on master.

Files with missing lines Patch % Lines
access/grpc/grpc.go 75.34% 11 Missing and 7 partials ⚠️
access/grpc/client.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #760      +/-   ##
==========================================
+ Coverage   52.92%   54.83%   +1.91%     
==========================================
  Files          35       35              
  Lines        5580     5788     +208     
==========================================
+ Hits         2953     3174     +221     
+ Misses       2231     2165      -66     
- Partials      396      449      +53     
Flag Coverage Δ
unittests 54.83% <69.62%> (+1.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

access/grpc/grpc.go Outdated Show resolved Hide resolved
@peterargue
Copy link
Contributor

@illia-malachyn please fix the conflicts, then this is ready to merge

@peterargue peterargue merged commit 785d4b6 into onflow:master Oct 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants