Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add value migration test for untyped capabilities #5434

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

SupunS
Copy link
Member

@SupunS SupunS commented Feb 22, 2024

Depends on: onflow/cadence#3125

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.87%. Comparing base (b7f56e3) to head (1318345).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           feature/stable-cadence    #5434       +/-   ##
===========================================================
- Coverage                   57.81%   41.87%   -15.94%     
===========================================================
  Files                         868       16      -852     
  Lines                       85796      800    -84996     
===========================================================
- Hits                        49602      335    -49267     
+ Misses                      32401      422    -31979     
+ Partials                     3793       43     -3750     
Flag Coverage Δ
unittests 41.87% <ø> (-15.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@turbolent turbolent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@turbolent turbolent merged commit 46d7563 into feature/stable-cadence Feb 23, 2024
50 of 51 checks passed
@turbolent turbolent deleted the supun/untyped-capability-test branch February 23, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants