New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Time To Seal metric to access node to track time it takes to seal a transaction #6512

Open

AndriiDiachuk wants to merge 21 commits into onflow:master from AndriiDiachuk:add-time-to-seal-metrics

+126 −3

Contributor

AndriiDiachuk commented Oct 1, 2024

Closes: #6448.


          Added TTS metrics

def498c

AndriiDiachuk requested review from peterargue and zhangchiqing as code owners

October 1, 2024 12:49

codecov-commenter commented Oct 1, 2024 •

edited

Loading

Codecov Report

Attention: Patch coverage is 6.52174% with 86 lines in your changes missing coverage. Please review.

Project coverage is 41.53%. Comparing base (0dde730) to head (7630bf9).

Files with missing lines	Patch %	Lines
module/metrics/transaction.go	0.00%	44 Missing ⚠️
...chronization/indexer/collection_executed_metric.go	19.35%	24 Missing and 1 partial ⚠️
cmd/access/node_builder/access_node_builder.go	0.00%	6 Missing ⚠️
cmd/observer/node_builder/observer_builder.go	0.00%	6 Missing ⚠️
module/mock/access_metrics.go	0.00%	2 Missing ⚠️
module/mock/transaction_metrics.go	0.00%	2 Missing ⚠️
module/metrics/noop.go	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6512      +/-   ##
==========================================
+ Coverage   41.28%   41.53%   +0.24%     
==========================================
  Files        2033     2033              
  Lines      145981   181785   +35804     
==========================================
+ Hits        60269    75501   +15232     
- Misses      79486   100055   +20569     
- Partials     6226     6229       +3

Flag	Coverage Δ
unittests	`41.53% <6.52%> (+0.24%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

AndriiDiachuk added 5 commits

October 1, 2024 17:00


          Generated mocks

8fffbb6


          Merge branch 'master' into add-time-to-seal-metrics

90addfd


          Merge branch 'master' into add-time-to-seal-metrics

9f4feb5


          Fixed failing test


          Merge branch 'master' of github.com:AndriiDiachuk/flow-go into add-ti…

41b0fad

…me-to-seal-metrics

Guitarheroua self-requested a review

October 2, 2024 14:22

Guitarheroua reviewed

View reviewed changes

module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved

Guitarheroua reviewed

View reviewed changes

module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved

Guitarheroua approved these changes

View reviewed changes

Collaborator

Guitarheroua left a comment

Have few small remarks.

AndriiDiachuk added 2 commits

October 3, 2024 13:13


          Renamed struct and id field

6348f03


          Using cached data for if statement

9bd79db

zhangchiqing requested changes

View reviewed changes

module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved

module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved

peterargue reviewed

View reviewed changes

module/metrics/transaction.go Outdated Show resolved Hide resolved

module/metrics/transaction.go Outdated Show resolved Hide resolved

module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved

module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved

AndriiDiachuk added 3 commits

October 14, 2024 12:14


          Merge branch 'master' of github.com:AndriiDiachuk/flow-go into add-ti…

a4e8537

…me-to-seal-metrics


          Expanded CollectionExecutedMetricImpl with map for sealed metrics

0cb72f8


          Removed ByID mocks and added filed init in constructor

82abb35

AndriiDiachuk requested review from peterargue, zhangchiqing and Guitarheroua

October 15, 2024 13:44

peterargue reviewed

View reviewed changes

module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved

module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved

module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved

AndriiDiachuk added 2 commits

October 16, 2024 12:56


          Merge branch 'master' into add-time-to-seal-metrics

a2c12e7


          Added mutex for sealed metrics

peterargue reviewed

View reviewed changes

module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved

module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved

module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved

module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved

module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved

module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved

module/state_synchronization/indexer/collection_executed_metric.go Outdated Show resolved Hide resolved

AndriiDiachuk and others added 3 commits

October 18, 2024 12:47


          Merge branch 'master' into add-time-to-seal-metrics

944451f


          Update module/state_synchronization/indexer/collection_executed_metri…

2ebce19

…c.go

Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>


          Update module/state_synchronization/indexer/collection_executed_metri…

b76f46b

…c.go

Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>

AndriiDiachuk and others added 5 commits

October 18, 2024 12:48


          Update module/state_synchronization/indexer/collection_executed_metri…

b3a1c84

…c.go

Co-authored-by: Peter Argue <89119817+peterargue@users.noreply.github.com>


          removed comment

70b82e6


          Using IdentifierMap instead of map

bf4d8e8


          Added err handling

ef8d3af


          Adding transactions also in Collection finilized method

7630bf9

AndriiDiachuk requested a review from peterargue

October 18, 2024 13:36

peterargue reviewed

View reviewed changes

module/state_synchronization/indexer/collection_executed_metric.go

               }
               // CollectionFinalized tracks collections to mark finalized
               func (c *CollectionExecutedMetricImpl) CollectionFinalized(light flow.LightCollection) {
               	if ti, found := c.collectionsToMarkFinalized.ByID(light.ID()); found {
               		for _, t := range light.Transactions {
               			c.accessMetrics.TransactionFinalized(t, ti)
+              			block, err := c.blocks.ByCollectionID(light.ID())

Contributor

peterargue Oct 18, 2024

this should be looked up outside of the loop, and the blockID result reused

module/state_synchronization/indexer/collection_executed_metric.go

+              	}
+              	var err error
+              	collectionExecutedMetricImpl.blockTransactions, err = stdmap.NewIdentifierMap(100)

Contributor

peterargue Oct 18, 2024

let's instantiate and pass this in like the other stdmap.* objects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet