[EVM] Offchain package - part 3 #6546
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if err != nil { | ||
| return err | ||
| } | ||
| return baseView.Commit() |
There was a problem hiding this comment.
I must miss something here.
Does the Commit call persist the balance update into database?
If we want to override the balance for making a dry call, do we also need to revert the balance update after the dry call? Because otherwise, the dry call isn't "dry" since the database is updated, it will affect the next dry call. No?
There was a problem hiding this comment.
storage that is passed to the baseView is of type storage.EphemeralStorage. so all the changes would be discarded.
m-Peter
reviewed
Oct 15, 2024
m-Peter
reviewed
Oct 15, 2024
m-Peter
reviewed
Oct 15, 2024
m-Peter
reviewed
Oct 15, 2024
m-Peter
reviewed
Oct 15, 2024
m-Peter
reviewed
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #6545
Context:
the Offchain package allows off-chain software like (GW) to follow the EVM chain and be able to replay all transactions. It also facilitates running queries (e.g. eth_Call), making the complex internal details hidden from the user.
This PR provides the query functionality that can be used to query account meta (e.g. Balance, ...) and make eth_call supporting passing optional tracer and overriding values.