[Observer] Ambiguous references #6547
Open
+49
−219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6547 +/- ##
==========================================
+ Coverage 41.26% 41.29% +0.02%
==========================================
Files 2031 2031
Lines 145883 145783 -100
==========================================
- Hits 60204 60201 -3
+ Misses 79459 79360 -99
- Partials 6220 6222 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| return nil, fmt.Errorf("could not create bootstrap identities: %w", err) | ||
| } | ||
|
|
||
| for _, b := range ids { |
There was a problem hiding this comment.
@peterargue I think, this is the correct fix from Uliana, as for me these two for loops look identical, sort of copy-paste mistake.
Guitarheroua
approved these changes
Oct 10, 2024
…m:The-K-R-O-K/flow-go into UlyanaAndrukhiv/6344-ambiguous-references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #6344
Context
This PR resolves ambiguities in structs references to improve code clarity and consistency in the codebase.
Specifically, it:
bootstrapNodeAddressesandbootstrapNodePublicKeysconfiguration fields in theFlowNodeBuilderand reused them in thefollowerandobserver.BuildPublicLibp2pNodeforfollowerandobserverbuilders to avoid duplication of code.