Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Backport transaction insufficient balance #6549

Open
wants to merge 4 commits into
base: v0.37
Choose a base branch
from

Conversation

Guitarheroua
Copy link
Collaborator

Close #6449

Backport implementation of filtering out transactions with insufficient transaction fees

…-metrics-for-tx-validator

[Access] Added metrics for transaction validator
…-fail-or-warn-tx-balance

[Access] Implemented options to fail or warn when payer is not able to pay
…checking-payer-balance

[Access] Use Indexed height when checking payer balance
@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 31.10368% with 206 lines in your changes missing coverage. Please review.

Project coverage is 41.50%. Comparing base (bfed72e) to head (049d753).

Files with missing lines Patch % Lines
access/validator.go 45.00% 40 Missing and 4 partials ⚠️
cmd/access/node_builder/access_node_builder.go 0.00% 44 Missing ⚠️
cmd/observer/node_builder/observer_builder.go 0.00% 29 Missing ⚠️
module/metrics/transaction_validation.go 0.00% 26 Missing ⚠️
access/mock/blocks.go 0.00% 17 Missing ⚠️
module/mock/transaction_validation_metrics.go 0.00% 11 Missing ⚠️
...tasync/execution_data/processed_height_recorder.go 0.00% 8 Missing ⚠️
module/mock/access_metrics.go 0.00% 6 Missing ⚠️
module/mock/collection_metrics.go 0.00% 6 Missing ⚠️
engine/common/stop/stop_control.go 90.38% 4 Missing and 1 partial ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##            v0.37    #6549      +/-   ##
==========================================
+ Coverage   41.29%   41.50%   +0.20%     
==========================================
  Files        2021     1972      -49     
  Lines      145067   139905    -5162     
==========================================
- Hits        59910    58062    -1848     
+ Misses      78931    75791    -3140     
+ Partials     6226     6052     -174     
Flag Coverage Δ
unittests 41.50% <31.10%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…-add-stop-control

[Access] Stop Control feature for AN
@peterargue
Copy link
Contributor

Looks like there are some compiler errors in the integration tests

Error: ../engine/execution/rpc/engine.go:120:51: cannot use eng.handler (variable of type *handler) as "github.com/onflow/flow/protobuf/go/flow/execution".ExecutionAPIServer value in argument to execution.RegisterExecutionAPIServer: *handler does not implement "github.com/onflow/flow/protobuf/go/flow/execution".ExecutionAPIServer (missing method GetTransactionExecutionMetricsAfter)
Error: ../engine/execution/rpc/engine.go:172:38: cannot use (*handler)(nil) (value of type *handler) as "github.com/onflow/flow/protobuf/go/flow/execution".ExecutionAPIServer value in variable declaration: *handler does not implement "github.com/onflow/flow/protobuf/go/flow/execution".ExecutionAPIServer (missing method GetTransactionExecutionMetricsAfter)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants