[EVM] Fix COA ownership proof #6550
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6550 +/- ##
==========================================
- Coverage 41.26% 41.09% -0.18%
==========================================
Files 2031 1993 -38
Lines 145883 142819 -3064
==========================================
- Hits 60204 58696 -1508
+ Misses 79459 78076 -1383
+ Partials 6220 6047 -173
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Do we want to create a new PR for porting the changes deployed and maybe we close this one ? |
turbolent
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
COA ownership proof verification did not work if the keys used had a non-0 index due to confusing the account key index and the index of the key in the key list.
See discussion: https://discord.com/channels/613813861610684416/1167476806333513800/1293534831036071947
I fixed the issue and (hopefully) made the code a bit more clear.
This is a contract change only, so no software update is needed to deploy this on existing networks, we only need to update the contract there.