-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Access] Improve error messages when querying old blocks #6554
Open
UlyanaAndrukhiv
wants to merge
7
commits into
onflow:master
Choose a base branch
from
The-K-R-O-K:UlyanaAndrukhiv/4904-improve-error-messages-for-old-blocks
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Access] Improve error messages when querying old blocks #6554
UlyanaAndrukhiv
wants to merge
7
commits into
onflow:master
from
The-K-R-O-K:UlyanaAndrukhiv/4904-improve-error-messages-for-old-blocks
+171
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6554 +/- ##
=======================================
Coverage 41.28% 41.28%
=======================================
Files 2033 2033
Lines 145981 146000 +19
=======================================
+ Hits 60269 60278 +9
- Misses 79486 79495 +9
- Partials 6226 6227 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
peterargue
reviewed
Oct 17, 2024
peterargue
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4904
Context
This PR improves error messaging on Access nodes for block height-based queries:
ExecuteScriptAtBlockHeight
,GetBlockByHeight
,GetBlockHeaderByHeight
,GetEventsForHeightRange
,GetAccountAtBlockHeight
,GetAccountBalanceAtBlockHeight
,GetAccountKeyAtBlockHeight
,GetAccountKeysAtBlockHeight
.Errors are now categorized based on the queried height:
Spork Root Height:
Instructs the caller to use a historic node.Node’s Root Height:
Suggests querying a different Access node (if the node was started after a spork).Updated and added unit tests to validate the new messaging logic.