[EVM] Adding account/slot/code iterators to the base storage #6555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramtinms
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6555 +/- ##
==========================================
+ Coverage 41.28% 41.54% +0.25%
==========================================
Files 2033 2035 +2
Lines 145981 181915 +35934
==========================================
+ Hits 60269 75568 +15299
- Misses 79486 100107 +20621
- Partials 6226 6240 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fxamacker
approved these changes
Oct 11, 2024
janezpodhostnik
approved these changes
Oct 18, 2024
| @@ -0,0 +1,163 @@ | |||
| package state | |||
There was a problem hiding this comment.
should this perhaps be in util somewhere?
zhangchiqing
approved these changes
Oct 19, 2024
Comment on lines
+342
to
+344
| require.Equal(t, nonces[acc.Address], acc.Nonce) | ||
| require.Equal(t, balances[acc.Address].Uint64(), acc.Balance.Uint64()) | ||
| require.Equal(t, codeHashes[acc.Address], acc.CodeHash) |
There was a problem hiding this comment.
The deletion ensures we see all unique account. Otherwise, returning the same account would also pass the tests.
Suggested change
| require.Equal(t, nonces[acc.Address], acc.Nonce) | |
| require.Equal(t, balances[acc.Address].Uint64(), acc.Balance.Uint64()) | |
| require.Equal(t, codeHashes[acc.Address], acc.CodeHash) | |
| require.Equal(t, nonces[acc.Address], acc.Nonce) | |
| delete(nonces, acc.Address) | |
| require.Equal(t, balances[acc.Address].Uint64(), acc.Balance.Uint64()) | |
| delete(balances, acc.Address) | |
| require.Equal(t, codeHashes[acc.Address], acc.CodeHash) | |
| delete(codeHashes, acc.Address) |
Comment on lines
+390
to
+391
| require.Equal(t, codeByCodeHash[cic.Hash], cic.Code) | ||
| require.Equal(t, refCountByCodeHash[cic.Hash], cic.RefCounts) |
There was a problem hiding this comment.
Suggested change
| require.Equal(t, codeByCodeHash[cic.Hash], cic.Code) | |
| require.Equal(t, refCountByCodeHash[cic.Hash], cic.RefCounts) | |
| require.Equal(t, codeByCodeHash[cic.Hash], cic.Code) | |
| delete(codeByCodeHash, cic.Hash) | |
| require.Equal(t, refCountByCodeHash[cic.Hash], cic.RefCounts) | |
| delete(refCountByCodeHash, cic.Hash) |
| break | ||
| } | ||
| require.Equal(t, addr, slot.Address) | ||
| require.Equal(t, values[slot.Key], slot.Value) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some utility methods to the base storage, for iterating over accounts, codes and slots. This functionality is used later by an evm state exporter utility command (follow up PRs are coming).