Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Improve bounds checking in rest converters #6567

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

AndriiDiachuk
Copy link
Contributor

Closes: #6564

@codecov-commenter
Copy link

codecov-commenter commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 41.57%. Comparing base (0dde730) to head (8595b62).

Files with missing lines Patch % Lines
engine/access/rest/util/converter.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6567      +/-   ##
==========================================
+ Coverage   41.28%   41.57%   +0.28%     
==========================================
  Files        2033     2033              
  Lines      145981   181701   +35720     
==========================================
+ Hits        60269    75538   +15269     
- Misses      79486    99940   +20454     
+ Partials     6226     6223       -3     
Flag Coverage Δ
unittests 41.57% <0.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndriiDiachuk AndriiDiachuk marked this pull request as ready for review October 18, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Access] Improve bounds checking in rest converters
2 participants