Skip to content

Commit

Permalink
Merge pull request #1404 from onflow/amlandeep/create-register-id-entity
Browse files Browse the repository at this point in the history
[Execution Data] Change registerID definition to match Ledger.RegisterID
  • Loading branch information
koko1123 authored Nov 17, 2023
2 parents 137b7ad + e1d2ab4 commit 5baffff
Show file tree
Hide file tree
Showing 9 changed files with 153 additions and 75 deletions.
11 changes: 11 additions & 0 deletions protobuf/flow/entities/register.proto
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
syntax = "proto3";

package flow.entities;

option go_package = "github.com/onflow/flow/protobuf/go/flow/entities";
option java_package = "org.onflow.protobuf.entities";

message RegisterID {
string owner = 1;
string key = 2;
}
3 changes: 2 additions & 1 deletion protobuf/flow/executiondata/executiondata.proto
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ option java_package = "org.onflow.protobuf.executiondata";

import "flow/entities/block_execution_data.proto";
import "flow/entities/event.proto";
import "flow/entities/register.proto";
import "google/protobuf/timestamp.proto";

// Execution Data API provides access to execution data from the Flow network
Expand Down Expand Up @@ -221,7 +222,7 @@ message GetRegisterValuesRequest {
uint64 block_height = 1;

// Register IDs of the Ledger.RegisterID format with an owner and key.
repeated bytes register_ids = 2;
repeated entities.RegisterID register_ids = 2;
}

// response for GetRegisterValues
Expand Down
4 changes: 0 additions & 4 deletions protobuf/go/flow/access/access_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

88 changes: 88 additions & 0 deletions protobuf/go/flow/entities/register.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions protobuf/go/flow/execution/execution_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

106 changes: 52 additions & 54 deletions protobuf/go/flow/executiondata/executiondata.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions protobuf/go/flow/executiondata/executiondata_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions protobuf/go/flow/legacy/access/access_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions protobuf/go/flow/legacy/execution/execution_grpc.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 5baffff

Please sign in to comment.