Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hc metadata parent #119

Merged
merged 4 commits into from
Jul 10, 2023
Merged

Hc metadata parent #119

merged 4 commits into from
Jul 10, 2023

Conversation

FelipeRibeiroLabs
Copy link
Collaborator

No description provided.

austinkline
austinkline requested changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@austinkline austinkline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small pieces, looks good otherwise so far!

  1. Comment cleanup
  2. How should a parent remove a display on a child?

contracts/HybridCustody.cdc Outdated Show resolved Hide resolved
contracts/HybridCustody.cdc Outdated Show resolved Hide resolved
@sisyphusSmiling
Copy link
Collaborator

How should a parent remove a display on a child?

I think setting as nil like you mentioned is a lightweight method for deletion, and an upsert if not nil makes sense to me for this use case.

@FelipeRibeiroLabs FelipeRibeiroLabs merged commit 8460edf into main Jul 10, 2023
1 check passed
@FelipeRibeiroLabs FelipeRibeiroLabs deleted the hc-metadata-parent branch July 10, 2023 15:09
@sisyphusSmiling sisyphusSmiling mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinkline austinkline austinkline approved these changes

@sisyphusSmiling sisyphusSmiling Awaiting requested review from sisyphusSmiling

@web3ashlee web3ashlee Awaiting requested review from web3ashlee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FelipeRibeiroLabs @sisyphusSmiling @austinkline