-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FungibleToken Factory Manager Setup Transaction #152
Conversation
Nice to see this one! It looks like we ended up adding some other types for to our flowty-maintained testnet resource Are we missing factories for some of these types? I'll look around at standard contracts to see if the missing combinations are generally in use |
Looks like there's a contract I do like consolidating the factories into a single contract, but kinda late into the game to switch up the pattern. What do you think about deploying another contract defining such a Factory? |
Yeah... I didn't even think to consolidate them until I needed something for testing and threw it all together 🙁 I think it's totally fine to stick with how we're doing it and make a new contract. They're tiny, which means it's easy for a reader to understand exactly what it's for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have a test for this somewhere?
No worries @austinkline, I didn't consider it either. I'll add the contract to this PR and can add the new Factory to the hosted Mainnet Manager. Good callout @joshuahannan I'll add test cases |
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
=======================================
Coverage 82.50% 82.50%
=======================================
Files 4 4
Lines 343 343
=======================================
Hits 283 283
Misses 60 60 |
Closes: #151