-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend AccountPublic to allow retrieval of Factory and Filter capabilities #153
Extend AccountPublic to allow retrieval of Factory and Filter capabilities #153
Conversation
Codecov Report
@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 82.50% 82.31% -0.19%
==========================================
Files 4 4
Lines 343 345 +2
==========================================
+ Hits 283 284 +1
- Misses 60 61 +1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, great additions! Added a few np & questions.
…ter capabilities. Without this, it's very difficult to detect whether a certain capability is allowed to be retrieved unless you run scripts manually. With helper method like this (I'm sure others will be needed), you can borrow and return details of the filter/factory yourself and then process them offline
150783f
to
1151139
Compare
Sorry for the delay, addressed comments @sisyphusSmiling |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @austinkline!
FYI these updates have been deployed in the following transactions: |
Without this, it's very difficult to detect whether a certain capability is allowed to be retrieved unless you run scripts manually. With helper methods like this (I'm sure others will be needed), you can borrow and return details of the filter/factory yourself and then process them offline