Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-Crescendo updates #172

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Post-Crescendo updates #172

merged 5 commits into from
Sep 6, 2024

Conversation

sisyphusSmiling
Copy link
Collaborator

@sisyphusSmiling sisyphusSmiling commented Sep 6, 2024

Closes: #165 #171

Description

  • Replaces existing node modules dependency system with Flow CLI's dependency manager for consistency with other onflow repos
  • Updates CI commands to use the Flow CLI flow command found in v2.0.0
  • Removes Previewnet deployment addresses as that network will be deprecated
  • Removes the code normalization script which has been integrated with the flow test command
  • Removes the outdated .gitmodules file, a remnant from when this repo used git submodules

Also, outside of the context of this PR, the new NFTCollectionFactory and FTVaultFactory (#164) contracts have been deployed on Testnet & Mainnet. After deployment, the existing hosted factory managers (see README) have been configured with the setup transactions already found in this repo.

@sisyphusSmiling sisyphusSmiling self-assigned this Sep 6, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.48%. Comparing base (3a09212) to head (6830315).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #172   +/-   ##
=======================================
  Coverage   91.48%   91.48%           
=======================================
  Files           4        4           
  Lines         364      364           
=======================================
  Hits          333      333           
  Misses         31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sisyphusSmiling sisyphusSmiling marked this pull request as ready for review September 6, 2024 00:05
@sisyphusSmiling sisyphusSmiling merged commit 310134d into main Sep 6, 2024
1 check passed
@sisyphusSmiling sisyphusSmiling deleted the gio/post-crescendo-updates branch September 6, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Deploy NFTCollectionFactory and FTVaultFactory contracts post-migration
3 participants