move examples gateway #992
Open
+887
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
XinyaoWa
approved these changes
Oct 21, 2024
letonghan
approved these changes
Oct 21, 2024
yao531441
approved these changes
Oct 21, 2024
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Spycsh
approved these changes
Oct 21, 2024
Spycsh
reviewed
Oct 29, 2024
ChatQnA/chatqna.py
Outdated
| def __init__(self, host="0.0.0.0", port=8000): | ||
| self.host = host | ||
| self.port = port | ||
| ServiceOrchestrator.align_inputs = align_inputs | ||
| ServiceOrchestrator.align_outputs = align_outputs | ||
| ServiceOrchestrator.align_generator = align_generator | ||
| self.megaservice = ServiceOrchestrator() | ||
|
|
||
| super().__init__( |
There was a problem hiding this comment.
The graph definition should run before the gateway is started, otherwise the DAG is not recognized correctly by the gateway and the gateway just will be forked to another process without the graph definition. One change could be e.g.
self.megaservice = ServiceOrchestrator()
self.add_remote_service() ## Call here to make sure megaservice know the graph
super().__init__(
megaservice=self.megaservice,
host=self.host,
port=self.port,
endpoint="/v1/audioqna",
input_datatype=AudioChatCompletionRequest,
output_datatype=ChatCompletionResponse,
)
There was a problem hiding this comment.
update code, please review again~ Thanks~
There was a problem hiding this comment.
I've reproduced the subsequent CI issues. I guess we need to set MEGA_SERVICE_HOST_IP=0.0.0.0 after this modification.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
move examples gateway implementation from GenAIComps to GenAIExamples