Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine ibm, aws into tabs, add tabset for getting started #230

Merged
merged 6 commits into from
Oct 28, 2024

Conversation

devpramod
Copy link
Contributor

No description provided.

Signed-off-by: devpramod <pramod.pai@intel.com>
Copy link
Collaborator

@tomlenth tomlenth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thx!

Copy link
Contributor

@louie-tsai louie-tsai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. minor comments

getting-started/README.md Show resolved Hide resolved
getting-started/README.md Outdated Show resolved Hide resolved
getting-started/README.md Outdated Show resolved Hide resolved
getting-started/README.md Outdated Show resolved Hide resolved
getting-started/README.md Show resolved Hide resolved
@louie-tsai
Copy link
Contributor

@devpramod do you need me to add GCP contents?

getting-started/README.md Outdated Show resolved Hide resolved
getting-started/README.md Outdated Show resolved Hide resolved
getting-started/README.md Outdated Show resolved Hide resolved
getting-started/README.md Outdated Show resolved Hide resolved
getting-started/README.md Show resolved Hide resolved
getting-started/README.md Outdated Show resolved Hide resolved
@yinghu5 yinghu5 self-requested a review October 28, 2024 00:55
Copy link
Collaborator

@yinghu5 yinghu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice to have

yinghu5 and others added 4 commits October 28, 2024 08:57
Co-authored-by: Malini Bhandaru <malini.bhandaru@intel.com>
Co-authored-by: Malini Bhandaru <malini.bhandaru@intel.com>
Co-authored-by: Louie Tsai <louie.tsai@intel.com>
Co-authored-by: Louie Tsai <louie.tsai@intel.com>
@NeoZhangJianyu
Copy link
Collaborator

@devpramod
Have you verified the format of html after convert the md to html locally?
There are code for sphinx grammar.

Signed-off-by: aice-support <ai.tce.support.baton@intel.com>
@yinghu5 yinghu5 merged commit d4075b2 into opea-project:main Oct 28, 2024
3 checks passed
yinghu5 added a commit that referenced this pull request Oct 28, 2024
NeoZhangJianyu pushed a commit that referenced this pull request Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants