sync: smoother clear with coroutines (fixes #4647) (#4648)

Co-authored-by: Kuljeet Singh Bhengura <47841620+Kuljeet1998@users.noreply.github.com> Co-authored-by: dogi <dogi@users.noreply.github.com>
open-learning-exchange · Oct 16, 2024 · d1e770d · d1e770d
1 parent cc57d11
commit d1e770d
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 13 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -10,8 +10,8 @@ android {
         applicationId "org.ole.planet.myplanet"
         minSdkVersion 26
         targetSdkVersion 34
-        versionCode 2033
-        versionName "0.20.33"
+        versionCode 2034
+        versionName "0.20.34"
         ndkVersion '21.3.6528147'
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
         vectorDrawables.useSupportLibrary = true

diff --git a/app/src/main/java/org/ole/planet/myplanet/ui/SettingActivity.kt b/app/src/main/java/org/ole/planet/myplanet/ui/SettingActivity.kt
@@ -20,6 +20,9 @@ import androidx.preference.PreferenceFragmentCompat
 import androidx.preference.PreferenceManager
 import androidx.preference.SwitchPreference
 import io.realm.Realm
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.launch
 import org.ole.planet.myplanet.MainApplication.Companion.mRealm
 import org.ole.planet.myplanet.MainApplication.Companion.setThemeMode
 import org.ole.planet.myplanet.R
@@ -135,9 +138,11 @@ class SettingActivity : AppCompatActivity() {
                 preference.onPreferenceClickListener = OnPreferenceClickListener {
                     AlertDialog.Builder(requireActivity()).setTitle(R.string.are_you_sure)
                         .setPositiveButton(R.string.yes) { _: DialogInterface?, _: Int ->
-                            clearRealmDb()
-                            clearSharedPref()
-                            restartApp()
+                            CoroutineScope(Dispatchers.Main).launch {
+                                clearRealmDb()
+                                clearSharedPref()
+                                restartApp()
+                            }
                         }.setNegativeButton(R.string.no, null).show()
                     false
                 }

diff --git a/app/src/main/java/org/ole/planet/myplanet/ui/sync/SyncActivity.kt b/app/src/main/java/org/ole/planet/myplanet/ui/sync/SyncActivity.kt
@@ -19,6 +19,10 @@ import androidx.recyclerview.widget.RecyclerView
 import com.afollestad.materialdialogs.*
 import com.google.android.material.textfield.TextInputLayout
 import io.realm.*
+import kotlinx.coroutines.CoroutineScope
+import kotlinx.coroutines.Dispatchers
+import kotlinx.coroutines.launch
+import kotlinx.coroutines.withContext
 import kotlinx.coroutines.launch
 import kotlinx.serialization.json.Json
 import okhttp3.ResponseBody
@@ -144,9 +148,11 @@ abstract class SyncActivity : ProcessUserDataActivity(), SyncListener, CheckVers
         AlertDialog.Builder(this, R.style.AlertDialogTheme)
             .setMessage(message)
             .setPositiveButton(getString(R.string.clear_data)) { _, _ ->
-                clearRealmDb()
-                clearSharedPref()
-                restartApp()
+                CoroutineScope(Dispatchers.Main).launch {
+                    clearRealmDb()
+                    clearSharedPref()
+                    restartApp()
+                }
             }
             .setNegativeButton(getString(R.string.cancel)) { _, _ ->
                 onCancel()
@@ -850,12 +856,17 @@ abstract class SyncActivity : ProcessUserDataActivity(), SyncListener, CheckVers
         lateinit var cal_today: Calendar
         lateinit var cal_last_Sync: Calendar
 
-        fun clearRealmDb() {
-            val realm = Realm.getDefaultInstance()
-            realm.executeTransaction { transactionRealm ->
-                transactionRealm.deleteAll()
+        suspend fun clearRealmDb() {
+            withContext(Dispatchers.IO) {
+                val realm = Realm.getDefaultInstance()
+                try {
+                    realm.executeTransaction { transactionRealm ->
+                        transactionRealm.deleteAll()
+                    }
+                } finally {
+                    realm.close()
+                }
             }
-            realm.close()
         }
 
         fun clearSharedPref() {